Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement neighbors message tracking #2931

Open
EclesioMeloJunior opened this issue Nov 8, 2022 · 0 comments
Open

Implement neighbors message tracking #2931

EclesioMeloJunior opened this issue Nov 8, 2022 · 0 comments
Assignees
@jimjbrettj
Labels
C-complex Complex changes across multiple modules. Possibly will require additional research. P-critical this must be fixed immediately or contributors or users will be severely impacted. S-grandpa issues related to block finality. S-sync-westend related to particular network syncing.
Milestone
Full Node MVP

Comments

@EclesioMeloJunior
Copy link
Member

EclesioMeloJunior commented Nov 8, 2022 •
edited
Loading

Describe the bug

  • Currently, we send the neighbor message right after we receive a neighbor message from other peers, this is not the best approach.
  • We should be able to send a neighbor message without rely on messages from other nodes (mainly substrate nodes)
  • This enables Gossamer to receive commit messages and stay up-to-date with new block finalization
@EclesioMeloJunior EclesioMeloJunior self-assigned this Nov 17, 2022
@EclesioMeloJunior EclesioMeloJunior removed their assignment Nov 27, 2023
@EclesioMeloJunior EclesioMeloJunior changed the title Ensure the connection is in a proper state before sending the neighbor message Implement neighbors message tracking Sep 13, 2024
EclesioMeloJunior added a commit that referenced this issue Sep 13, 2024
@EclesioMeloJunior
chore: TODO(#2931)
f233d05
@EclesioMeloJunior EclesioMeloJunior self-assigned this Sep 18, 2024
@EclesioMeloJunior EclesioMeloJunior added C-complex Complex changes across multiple modules. Possibly will require additional research. P-high this should be addressed ASAP. S-sync-westend related to particular network syncing. S-grandpa issues related to block finality. labels Sep 18, 2024
@EclesioMeloJunior EclesioMeloJunior mentioned this issue Sep 18, 2024
Closed
2 tasks
@EclesioMeloJunior EclesioMeloJunior added this to the Full Node MVP milestone Sep 19, 2024
@EclesioMeloJunior EclesioMeloJunior mentioned this issue Sep 19, 2024
Open
@EclesioMeloJunior EclesioMeloJunior added P-critical this must be fixed immediately or contributors or users will be severely impacted. and removed P-high this should be addressed ASAP. labels Sep 19, 2024
@jimjbrettj jimjbrettj self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimjbrettj jimjbrettj

Labels
C-complex Complex changes across multiple modules. Possibly will require additional research. P-critical this must be fixed immediately or contributors or users will be severely impacted. S-grandpa issues related to block finality. S-sync-westend related to particular network syncing.
Projects
None yet
Milestone
Full Node MVP
Development

No branches or pull requests
4 participants
@danforbes @P1sar @EclesioMeloJunior @jimjbrettj