Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dot/node) Start websocket server only with --ws flag #1671

Merged
merged 9 commits into from
Jul 6, 2021
Merged

fix(dot/node) Start websocket server only with --ws flag #1671

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
34cf4da
start ws server when ws flag is alone
EclesioMeloJunior Jul 2, 2021
fdd6560
Merge branch 'development' into eclesio/doing-ws-flag-works
EclesioMeloJunior Jul 2, 2021
1cdc4d3
Merge branch 'development' into eclesio/doing-ws-flag-works
EclesioMeloJunior Jul 6, 2021
7b8cf3d
chore: remove unecessary parenthesis
EclesioMeloJunior Jul 6, 2021
09114b3
Merge branch 'eclesio/doing-ws-flag-works' of github.com:ChainSafe/go…
EclesioMeloJunior Jul 6, 2021
a194c46
Merge branch 'development' into eclesio/doing-ws-flag-works
noot Jul 6, 2021
e353620
Merge branch 'development' into eclesio/doing-ws-flag-works
EclesioMeloJunior Jul 6, 2021
3f25c3b
Merge branch 'development' into eclesio/doing-ws-flag-works
EclesioMeloJunior Jul 6, 2021
2aef5cc
Merge branch 'development' into eclesio/doing-ws-flag-works
noot Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dot/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ func NewNode(cfg *Config, ks *keystore.GlobalKeystore, stopFunc func()) (*Node,
nodeSrvcs = append(nodeSrvcs, sysSrvc)

// check if rpc service is enabled
if enabled := cfg.RPC.Enabled; enabled {
if enabled := (cfg.RPC.Enabled || cfg.RPC.WS); enabled {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesis is not required.
Not idiomatic to use parenthesis in if-else in Go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed!

rpcSrvc := createRPCService(cfg, stateSrvc, coreSrvc, networkSrvc, bp, rt, sysSrvc)
nodeSrvcs = append(nodeSrvcs, rpcSrvc)
} else {
Expand Down