feat(lib/runtime): Implement `ext_offchain_http_request_start_version_1` host function #1947

EclesioMeloJunior · 2021-10-31T18:16:05Z

Changes

Add ext_offchain_http_request_start_version_1 host function
Create a HTTP set using a singleton pattern to manage HTTP requests
Depends on feat: implement rtm_offchain_http_start_request function polkadot-spec#10

Tests

go test -run ^Test_ext_offchain_http_request_start_version_1$ github.com/ChainSafe/gossamer/lib/runtime/wasmer

Issues

Closes to Implement ext_offchain_http_request_start host function #2017

Primary Reviewer

@arijitAD

arijitAD · 2021-11-01T13:22:08Z

lib/runtime/offchain/httpset.go

+}
+
+// OnceHTTPSet
+func OnceHTTPSet() *Set {


Can this function return void?

Function removed

arijitAD · 2021-11-01T13:22:58Z

lib/runtime/offchain/httpset.go

+	"sync"
+)
+
+var (


Ideally, we should avoid global variables and make this struct part of some other struct like runtime.

I think this is probably ok as we might have multiple runtime instances but only one offchain HTTP handler. but I guess, we could always just have the runtimes point to the same handler

arijitAD · 2021-11-01T13:23:30Z

lib/runtime/wasmer/imports.go

@@ -1682,6 +1684,48 @@ func ext_offchain_sleep_until_version_1(_ unsafe.Pointer, deadline C.int64_t) {
 	logger.Warn("unimplemented")
 }

+//export ext_offchain_http_request_start_version_1
+func ext_offchain_http_request_start_version_1(context unsafe.Pointer, methodSpan, uriSpan, metaSpan C.int64_t) C.int64_t {
+	logger.Debug("[ext_offchain_submit_transaction_version_1] executing...")


ext_offchain_http_request_start_version_1

I think we updated the logger to already log the function name, so you can probably remove the function name entirely

arijitAD · 2021-11-01T13:26:57Z

lib/runtime/offchain/httpset.go

+	p.mtx.Lock()
+	defer p.mtx.Unlock()
+
+	p.reqs = append(p.reqs[:id], p.reqs[id+1:]...)


We should use a map instead of a slice because when we are removing we are shifting the index and if we call get again after removal we will get an incorrect index.

arr : [1,2,3,4,5,6] Remove(2) arr: [1,2,4,5,6] Get(3) will return 5 instead of 4.

Also, the Get logic of length checking will fail.

arijitAD · 2021-11-01T13:29:17Z

lib/runtime/wasmer/imports_test.go

@@ -232,6 +232,59 @@ func Test_ext_offchain_local_storage_clear_version_1_Local(t *testing.T) {
 	require.Nil(t, val)
 }

+func Test_ext_offchain_http_request_start_version_1(t *testing.T) {


Test_ext_offchain_http_request_start_version_1 is getting failed. Implement rtm_ext_offchain_http_request_start_version_1 in hostapi and update hostApi wasm url.

I changed the commit id, now the test should work

arijitAD · 2021-11-01T13:32:48Z

lib/runtime/wasmer/imports.go

+	uri := asMemorySlice(instanceContext, uriSpan)
+
+	reqID, err := offchain.HTTPSet.StartRequest(string(httpMethod), string(uri))
+	if err != nil {


Set the result to error.

err = result.Set(scale.Err, nil)

arijitAD · 2021-11-01T13:34:08Z

lib/runtime/wasmer/imports_test.go

+	encMethod, err := scale.Marshal([]byte("GET"))
+	require.NoError(t, err)
+
+	encUri, err := scale.Marshal([]byte("https://chainsafe.io"))


Can you start an HTTP mock server and request that? Because this test will fail without the internet or if Chainsafe domain is down.
This is applicable when you make the actual request in other offchain function.

the host function does not execute any request so this is just a URI formatted string to the runtime

… into eclesio/offchain-http

noot · 2021-11-05T16:55:56Z

lib/runtime/offchain/httpset.go

+type requestIDBuffer chan int16
+
+// newIntBuffer creates the request id buffer starting from 1 till @buffSize (by default @buffSize is 1000)
+func newIntBuffer(buffSize int16) *requestIDBuffer {


does this need to return a pointer? you can change the receiver methods below to be (b requestIDBuffer), then you don't need to dereference it in the methods

noot · 2021-11-05T16:57:09Z

lib/runtime/offchain/httpset.go

+// HTTPSet holds a pool of concurrent http request calls
+type HTTPSet struct {
+	mtx    *sync.Mutex
+	reqs   map[int16]*http.Request


is there a chance this map will be accesses concurrently? I think potentially

yes! There is mutexes locks in StartRequest and Remove and I've added locks on Get tho

noot · 2021-11-08T18:22:45Z

lib/runtime/offchain/httpset.go

+
+// HTTPSet holds a pool of concurrent http request calls
+type HTTPSet struct {
+	mtx    *sync.Mutex


you can embed this, so you don't need to call p.mtx.Lock(), you can just call p.Lock() and same for Unlock()

Suggested change

mtx *sync.Mutex

sync.Mutex

// etc.

noot

looks good - just embed the lock :)

codecov · 2021-11-09T21:23:15Z

Codecov Report

Merging #1947 (1598499) into development (dd80c09) will decrease coverage by 0.27%.
The diff coverage is 73.33%.

@@               Coverage Diff               @@
##           development    #1947      +/-   ##
===============================================
- Coverage        60.22%   59.94%   -0.28%     
===============================================
  Files              180      185       +5     
  Lines            18189    26316    +8127     
===============================================
+ Hits             10954    15776    +4822     
- Misses            5420     8667    +3247     
- Partials          1815     1873      +58

Flag	Coverage Δ
unit-tests	`59.94% <73.33%> (-0.28%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
lib/runtime/constants.go	`0.00% <ø> (ø)`
lib/runtime/types.go	`0.00% <ø> (ø)`
lib/runtime/offchain/httpset.go	`69.81% <69.81%> (ø)`
lib/runtime/wasmer/imports.go	`47.73% <71.42%> (+1.10%)`	⬆️
lib/runtime/wasmer/instance.go	`60.10% <100.00%> (-0.81%)`	⬇️
lib/transaction/types.go	`13.88% <0.00%> (-19.45%)`	⬇️
dot/rpc/modules/api_mocks.go	`88.88% <0.00%> (-11.12%)`	⬇️
lib/runtime/version.go	`62.61% <0.00%> (-8.05%)`	⬇️
dot/types/digest.go	`33.33% <0.00%> (-6.67%)`	⬇️
dot/rpc/modules/offchain.go	`74.00% <0.00%> (-5.49%)`	⬇️
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd80c09...1598499. Read the comment docs.

# [0.6.0](v0.5.0...v0.6.0) (2021-12-03) ### Bug Fixes * **babe:** Fix extrinsic format in block. ([#1530](#1530)) ([1a03b2a](1a03b2a)) * **ci:** add missing go-version matrix to fix development branch CI ([#2037](#2037)) ([6babe76](6babe76)) * **cmd/cfg:** Use Babe Lead value from toml config ([#2032](#2032)) ([06aa3e3](06aa3e3)) * cmd/gossamer: Generate random name if --name flag not set ([#1506](#1506)) ([3c05a88](3c05a88)) * confirm block import notifier is closed properly ([#1736](#1736)) ([ad2d85e](ad2d85e)) * **docs:** improve build-spec usage docs ([#1706](#1706)) ([2e164b4](2e164b4)) * **dot/core:** Add only extrinsic during chain reorg. ([#1609](#1609)) ([29413d4](29413d4)) * **dot/core:** Batch process transaction message. ([#1780](#1780)) ([0064836](0064836)) * **dot/core:** check transaction Validity.Propagate field to determine whether to propagate tx ([#1643](#1643)) ([81f23cc](81f23cc)) * **dot/core:** Fix handle transaction message test. ([#1607](#1607)) ([58b8725](58b8725)) * **dot/network, lib/grandpa:** fix handshake decoding and grandpa message handler sigabort ([#1631](#1631)) ([887f72c](887f72c)) * **dot/network, lib/grandpa:** fix node sync, improve devnet finality ([bcc7935](bcc7935)) * **dot/network:** add nil checks in connManager ([#2069](#2069)) ([7f9c042](7f9c042)) * **dot/network:** Check for size when decoding leb128. ([#1634](#1634)) ([d082b9e](d082b9e)) * **dot/network:** check if peer supports protocol ([#1617](#1617)) ([6bf66a4](6bf66a4)) * **dot/network:** decrease DHT find peers interval for gssmr nodes ([#1703](#1703)) ([08516a0](08516a0)) * **dot/network:** fix bugs in notifications protocol handlers; add metrics for inbound/outbound streams ([#2010](#2010)) ([8c2993d](8c2993d)) * **dot/network:** fix dht connection on discovery on devnet ([#2059](#2059)) ([da065b8](da065b8)) * **dot/network:** fix discovery between gossamer nodes ([#1594](#1594)) ([f4c79d3](f4c79d3)) * **dot/network:** fix justification request at head logic ([#1510](#1510)) ([98d1413](98d1413)) * **dot/network:** fix memory allocations with `sizedBufferPool` ([#1963](#1963)) ([e0b126b](e0b126b)) * **dot/network:** Fix missing digest in header ([#2092](#2092)) ([21ea85e](21ea85e)) * **dot/network:** Fix notification handshake and reuse stream. ([#1545](#1545)) ([a632dc4](a632dc4)) * **dot/network:** fix receiving notifications messages from substrate peers ([#1517](#1517)) ([fdf3c53](fdf3c53)) * **dot/network:** fix stream manager tests ([#1683](#1683)) ([e02eca4](e02eca4)) * **dot/network:** implement a handshake timeout ([#1615](#1615)) ([87c2f63](87c2f63)) * **dot/network:** Implement time based handle transaction ([#1942](#1942)) ([dd08424](dd08424)) * **dot/network:** move low reputation peer removal from network ConnManager to peer scoring logic (dot/peerstate) ([#2068](#2068)) ([ac16285](ac16285)), closes [#2039](#2039) * **dot/network:** Return on EOF error while reading stream. ([#1733](#1733)) ([f447eac](f447eac)) * **dot/network:** split stored streams and handshakeData into inbound and outbound ([#1553](#1553)) ([637050b](637050b)) * **dot/network:** update notificationsProtocol handshakeData to sync.Map ([#1492](#1492)) ([22f7269](22f7269)) * **dot/node:** Start websocket server only with `--ws` flag ([#1671](#1671)) ([6ecef3b](6ecef3b)) * **dot/state, lib/babe, lib/trie:** improve syncing between gossamer authority nodes ([#1613](#1613)) ([ca99fbf](ca99fbf)) * **dot/state, lib/grandpa:** update justification and SignedVote handling in database ([#1682](#1682)) ([bbdcd6f](bbdcd6f)) * **dot/state,dot/network:** improve memory usage when syncing ([#1491](#1491)) ([3b2ad8d](3b2ad8d)) * **dot/state:** add StorageState Lock/Unlock API for usage by babe and sync ([#1700](#1700)) ([3c22ace](3c22ace)) * **dot/state:** fix deadlock, fixes bootstrap syncing ([#1959](#1959)) ([dd80c09](dd80c09)) * **dot/state:** fix usage of trie.Snapshot ([#1489](#1489)) ([3880a40](3880a40)) * **dot/state:** track runtime per-block, fix runtime upgrades differing between forks ([#1638](#1638)) ([e133884](e133884)) * **dot/state:** update `*state.BlockState.AddBlockToBlockTree` to store block in `unfinalisedBlocksMap` ([#2006](#2006)) ([55d997f](55d997f)) * **dot/sync:** add nil header checks ([#2099](#2099)) ([a7d4be0](a7d4be0)) * **dot/sync:** fix block request and response logic ([#1907](#1907)) ([9c6283e](9c6283e)) * **dot/sync:** fix creating block response, fixes node sync between gossamer nodes ([#1572](#1572)) ([1328c80](1328c80)) * **dot/telemetry:** refactor telemetry to reduce CPU usage ([#1597](#1597)) ([bc31ac7](bc31ac7)) * **dot/types:** *types.Body to be of type []types.Extrinsic ([#1807](#1807)) ([4c09715](4c09715)) * **dot/types:** fix max value for digest ([#1687](#1687)) ([48405e7](48405e7)) * **dot:** fix `TestNewNode` ([#2070](#2070)) ([42908d0](42908d0)) * fix edit link ([#1507](#1507)) ([5089327](5089327)) * fix Kusama sync; add storageState lock in core.HandleTransactionMessage ([#1783](#1783)) ([1d688e4](1d688e4)) * **lib/babe, lib/runtime/wasmer:** fixes for v0.9.8+ runtime ([#2075](#2075)) ([2f9f80c](2f9f80c)) * **lib/babe:** add `--babe-lead` flag, update epoch handling logic ([#1895](#1895)) ([7abcce6](7abcce6)) * **lib/babe:** add pre-runtime digest before calling initialize_block ([#1581](#1581)) ([c1b26d3](c1b26d3)) * **lib/babe:** always use 2/3 of slot to produce block, re-add potentially valid txs to queue ([#1679](#1679)) ([cf93ad3](cf93ad3)) * **lib/babe:** call AddBlock in BABE synchronously ([#1585](#1585)) ([86acc43](86acc43)) * **lib/babe:** fix BABE state storing after building block ([#1536](#1536)) ([1a3dea2](1a3dea2)) * **lib/babe:** fix err log ([#1801](#1801)) ([a96f06a](a96f06a)) * **lib/babe:** fix setting first slot of network, fix loading BABE epoch params ([#1640](#1640)) ([5c3dbfe](5c3dbfe)) * **lib/babe:** fix timing for transition between epochs ([#1636](#1636)) ([57027db](57027db)) * **lib/blocktree:** fix blocktree bug ([#2060](#2060)) ([c17b53a](c17b53a)) * **lib/blocktree:** fix potential nil pointer dereference in `HighestCommonAncestor`, core `handleBlocksAsync` ([#1993](#1993)) ([f7f4463](f7f4463)) * **lib/blocktree:** fix setting leaves after blocktree pruning ([#1605](#1605)) ([58c0854](58c0854)) * **lib/blocktree:** removes the inconsistency to choose a deepest leaf ([#2094](#2094)) ([43d68e3](43d68e3)) * **lib/crypto/ed25519:** update ed25519 to use go-schnorrkel bip39 derivation ([#1488](#1488)) ([dfb95d2](dfb95d2)) * **lib/genesis:** Update missing and incorrect fields in genesis file. ([#1681](#1681)) ([8207704](8207704)) * **lib/grandpa:** fix grandpa stall and various bugs ([#1708](#1708)) ([67c93f4](67c93f4)) * **lib/grandpa:** fix grandpa vote message switch ([#2095](#2095)) ([461890c](461890c)) * **lib/grandpa:** fix threshold checking to be strictly greater than 2/3 ([#1891](#1891)) ([66ffe51](66ffe51)) * **lib/grandpa:** use `defaultGrandpaInterval` if not set, fixes error on startup ([#1982](#1982)) ([75627b5](75627b5)) * **lib/runtime/life:** remove import C from life ([#1923](#1923)) ([ed507d2](ed507d2)) * **lib/runtime:** update HOST_API_TEST_RUNTIME_URL to reference specific commit ([#1885](#1885)) ([666ed06](666ed06)) * **log-levels:** do not ignore configuration file log levels ([#2016](#2016)) ([80879b2](80879b2)) * pending bubble hidden after block included ([#1592](#1592)) ([5826322](5826322)) * persist node name ([#1543](#1543)) ([88b88f2](88b88f2)) * **pprof:** only run pprof service if enabled ([#2073](#2073)) ([55669c5](55669c5)) * **release:** Trigger release when pushed to main branch. ([#1566](#1566)) ([d445c97](d445c97)) * **rpc/subscription:** subscribe runtime version notify when version changes ([#1686](#1686)) ([9a76d39](9a76d39)) * Staging CI workflow ([#2034](#2034)) ([84ec792](84ec792)) * **trie:** memory leak fix in `lib/trie` ([#2009](#2009)) ([0ad5eb7](0ad5eb7)) * update deprecated package ([#1603](#1603)) ([f195204](f195204)) * update go-schnorrkel version ([#1557](#1557)) ([b86c7ff](b86c7ff)) * update gssmr genesis to use pallet_babe::SameAuthoritiesForever ([#1696](#1696)) ([fb0a751](fb0a751)) * update HOST_API_TEST_RUNTIME_URL ([#1898](#1898)) ([2ef59a8](2ef59a8)) * **utils:** create a specific folder for database ([#1598](#1598)) ([8c67795](8c67795)) ### Features * add --chain dev option ([#1561](#1561)) ([04a2969](04a2969)) * Add properties and chainId on build-spec command ([#1520](#1520)) ([b18290c](b18290c)) * cmd: implement import-runtime subcommand ([#1483](#1483)) ([d82b2da](d82b2da)) * **cmd/gossamer:** implement --telemetry-url parameter ([#1890](#1890)) ([b202e89](b202e89)), closes [#1502](#1502) * **cmd:** implement offline pruning of state trie ([#1564](#1564)) ([af9c925](af9c925)) * **devnet:** Local Gossamer Devnet ([#2008](#2008)) ([a520001](a520001)) * **dot/network, lib/grandpa:** request justification on receiving NeighbourMessage, verify justification on receipt ([#1529](#1529)) ([e1f9f42](e1f9f42)) * **dot/network:** Add cache for network message. ([#1511](#1511)) ([accaf69](accaf69)) * **dot/network:** add propagate return bool to messageHandler func type to determine whether to propagate message or not ([#1555](#1555)) ([0d6f488](0d6f488)) * **dot/network:** implement persistent peers functionality ([#1512](#1512)) ([7850532](7850532)) * **dot/network:** implement streamManager to cleanup not recently used streams ([#1611](#1611)) ([ba861bf](ba861bf)) * **dot/network:** request block justifications when near head ([#1499](#1499)) ([ae7012b](ae7012b)) * **dot/peerset:** Implement peer scoring ([#1791](#1791)) ([1c989ad](1c989ad)) * **dot/rpc/modules:** add `system_addReservedPeer` and `system_removeReservedPeer` RPC call ([#1712](#1712)) ([dba5922](dba5922)) * **dot/rpc:** Add `system_localListenAddresses` RPC call ([#1689](#1689)) ([c981d2e](c981d2e)) * **dot/rpc:** Implement `childstate_getKeys` rpc call ([#1800](#1800)) ([9b2f41e](9b2f41e)) * **dot/rpc:** implement sync_state_genSyncSpec RPC call ([#1827](#1827)) ([2186caf](2186caf)) * **dot/state:** implement online pruning of historical state tries ([#1596](#1596)) ([3eb9399](3eb9399)) * **dot/sync:** implement codeSubstitutes ([#1635](#1635)) ([d87aaeb](d87aaeb)) * dot/telemetry: Implement basic telemetry connection ([#1497](#1497)) ([fcb4159](fcb4159)) * **dot/telemetry:** Added connection retry ([#1904](#1904)) ([579a791](579a791)) * **dot/telemetry:** Added more telemetry messages in grandpa client ([#2043](#2043)) ([2e57d15](2e57d15)), closes [#1841](#1841) [#1842](#1842) * **dot/telemetry:** implement notify.finalized telemetry interface ([#1877](#1877)) ([de1a60d](de1a60d)) * **dot/telemetry:** implement substrate_number_leaves metrics ([#1926](#1926)) ([69823c0](69823c0)) * **dot/telemetry:** implement telemetry message network_state ([#1618](#1618)) ([a81844e](a81844e)) * **flags:** read log levels from flags ([#1953](#1953)) ([9694e46](9694e46)) * implement ext_default_child_storage_storage_kill_version_2 ([#1799](#1799)) ([c2908ae](c2908ae)) * implement ext_offchain_index_set_version_1 for wasmer runtime ([#1739](#1739)) ([96c30a6](96c30a6)) * **lib/babe:** add check of types.ConfigData.SecondarySlots for disabling secondary verification ([#1910](#1910)) ([cd27ae4](cd27ae4)) * **lib/grandpa:** fully verify justifications using GrandpaState ([#1544](#1544)) ([028d25e](028d25e)) * **lib/grandpa:** Include equivocatory nodes while creating justification ([#1911](#1911)) ([aca86b6](aca86b6)) * **lib/grandpa:** send NeighbourMessage to peers ([#1558](#1558)) ([322ccf9](322ccf9)) * **lib/runtime/wasmer:** implement ext_default_child_storage_storage_kill_version_3 ([#1878](#1878)) ([a719a60](a719a60)) * **lib/runtime/wasmer:** implement ext_offchain_local_storage_version_1 ([#1821](#1821)) ([0f63b17](0f63b17)) * **lib/runtime:** Implement `ext_offchain_http_request_add_header_version_1` host function ([#1994](#1994)) ([0a30b3d](0a30b3d)) * **lib/runtime:** Implement `ext_offchain_http_request_start_version_1` host function ([#1947](#1947)) ([974b1fc](974b1fc)) * **lib/runtime:** Implement `trie_blake2_256_verify_proof` host function ([#1920](#1920)) ([506565d](506565d)) * **lib/trie:** Implement `verify_proof` function ([#1883](#1883)) ([67bb5ef](67bb5ef)) * **lib/trie:** Implement limit for trie.ClearPrefix ([#1905](#1905)) ([becec9e](becec9e)) * **lib/trie:** Parallel hash trie. ([#1657](#1657)) ([22827e7](22827e7)) * **pprof:** Pprof HTTP server service ([#1991](#1991)) ([ce24ea9](ce24ea9)) * **rpc/subscription:** implement state_unsubscribeStorage ([#1574](#1574)) ([7574f10](7574f10)) * **rpc:** Implement `childstate_getChildStorage` RPC call ([#1832](#1832)) ([3d949f2](3d949f2)) * **rpc:** Implement `childstate_getStorageHash` RPC call ([#1805](#1805)) ([e539bd3](e539bd3)) * **rpc:** Implement `childstate_getStorageSize` RPC call ([#1810](#1810)) ([a04deb6](a04deb6)) * **rpc:** Implement `payment_queryInfo` RPC call ([#1826](#1826)) ([7a5deec](7a5deec)) * **rpc:** Implement `state_getReadProof` rpc call ([#1768](#1768)) ([865f80f](865f80f)) * **runtime:** implement custom logging handler that print function name ([#1825](#1825)) ([2b1276d](2b1276d)) * **telemetry:** send telemetry messages when GRANDPA receieves commit or vote messages ([#2015](#2015)) ([7bf40e1](7bf40e1)), closes [#1840](#1840) [#1839](#1839) [#1838](#1838) * **telemetry:** send txpool.import telemetry msg ([#1966](#1966)) ([ffc81bf](ffc81bf)) ### Reverts * Revert "feat(dot/rpc) implement `author_hasSessionKeys` RPC call (#1704)" (#1714) ([65380fd](65380fd)), closes [#1704](#1704) [#1714](#1714)

github-actions · 2021-12-03T21:06:08Z

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

…_1` host function (ChainSafe#1947) * feat: implement offchain http host functions * chore: decoding Result<i16, ()> * chore: adjust result encoding/decoding * chore: add export comment on Get * chore: change to map and update test wasm * chore: use request id buffer * chore: change to NewHTTPSet * chore: add export comment * chore: use pkg/scale to encode Result to wasm memory * chore: update naming and fix lint warns * chore: use buffer.put when remove http request * chore: add more comments * chore: add unit tests * chore: fix misspelling * chore: fix scale marshal to encode Result instead of Option<Result> * chore: ignore uneeded error * chore: fix unused params * chore: cannot remove unused params * chore: ignore deepsource errors * chore: add parallel to wasmer tests * chore: remove dereferencing * chore: fix param compatibility * chore: embed mutex iunto httpset struct * chore: update the hoost polkadot test runtime location * chore: fix request not available test

EclesioMeloJunior added 3 commits October 28, 2021 09:08

feat: implement offchain http host functions

2899a29

chore: decoding Result<i16, ()>

8f7a581

chore: adjust result encoding/decoding

4d6167f

EclesioMeloJunior requested review from arijitAD, edwardmack, jimjbrettj, kishansagathiya, noot, omar391 and timwu20 as code owners October 31, 2021 18:16

EclesioMeloJunior self-assigned this Oct 31, 2021

EclesioMeloJunior added runtime labels Oct 31, 2021

chore: add export comment on Get

faa5752

EclesioMeloJunior force-pushed the eclesio/offchain-http branch from 5439486 to faa5752 Compare October 31, 2021 18:20

arijitAD reviewed Nov 1, 2021

View reviewed changes

EclesioMeloJunior added 11 commits November 2, 2021 09:09

chore: change to map and update test wasm

e08300e

chore: use request id buffer

70e6351

chore: change to NewHTTPSet

ad8c0bb

chore: add export comment

5606599

Merge branch 'development' into eclesio/offchain-http

f2ca718

chore: use pkg/scale to encode Result to wasm memory

81c0fb9

Merge branch 'eclesio/offchain-http' of github.com:ChainSafe/gossamer…

6da5ad8

… into eclesio/offchain-http

chore: update naming and fix lint warns

fb21f11

Merge branch 'development' into eclesio/offchain-http

881fc51

Merge branch 'development' into eclesio/offchain-http

7444590

Merge branch 'development' into eclesio/offchain-http

8896ae5

EclesioMeloJunior requested a review from arijitAD November 3, 2021 21:36

EclesioMeloJunior changed the title ~~feat: implement ext_offchain_http_request_start_version_1 host function~~ feat: Implement ext_offchain_http_request_start_version_1 host function Nov 3, 2021

EclesioMeloJunior changed the title ~~feat: Implement ext_offchain_http_request_start_version_1 host function~~ feat(lib/runtime): Implement ext_offchain_http_request_start_version_1 host function Nov 3, 2021

EclesioMeloJunior added 8 commits November 3, 2021 17:56

chore: add unit tests

42ff50e

chore: fix misspelling

13d540a

chore: fix scale marshal to encode Result instead of Option<Result>

60a1f11

chore: ignore uneeded error

4cd379f

chore: fix unused params

f1130ad

chore: cannot remove unused params

5f980ab

chore: ignore deepsource errors

c8913d2

chore: add parallel to wasmer tests

fcb5da9

noot reviewed Nov 5, 2021

View reviewed changes

chore: remove dereferencing

dd89472

EclesioMeloJunior requested a review from noot November 5, 2021 19:52

noot reviewed Nov 8, 2021

View reviewed changes

noot approved these changes Nov 8, 2021

View reviewed changes

EclesioMeloJunior added 2 commits November 8, 2021 14:51

chore: fix param compatibility

8624e09

chore: embed mutex iunto httpset struct

427c183

arijitAD approved these changes Nov 9, 2021

View reviewed changes

EclesioMeloJunior added 2 commits November 9, 2021 16:01

chore: update the hoost polkadot test runtime location

750caa9

chore: fix request not available test

1598499

EclesioMeloJunior merged commit 974b1fc into development Nov 9, 2021

EclesioMeloJunior deleted the eclesio/offchain-http branch November 9, 2021 21:23

EclesioMeloJunior removed the Status: Review Needed label Nov 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(lib/runtime): Implement `ext_offchain_http_request_start_version_1` host function #1947

feat(lib/runtime): Implement `ext_offchain_http_request_start_version_1` host function #1947

EclesioMeloJunior commented Oct 31, 2021 •

edited

Loading

arijitAD Nov 1, 2021

EclesioMeloJunior Nov 2, 2021

arijitAD Nov 1, 2021

noot Nov 2, 2021

EclesioMeloJunior Nov 2, 2021

arijitAD Nov 1, 2021

noot Nov 2, 2021 •

edited

Loading

EclesioMeloJunior Nov 2, 2021

arijitAD Nov 1, 2021

arijitAD Nov 1, 2021

arijitAD Nov 1, 2021

EclesioMeloJunior Nov 2, 2021 •

edited

Loading

arijitAD Nov 1, 2021

EclesioMeloJunior Nov 2, 2021

arijitAD Nov 1, 2021 •

edited

Loading

EclesioMeloJunior Nov 2, 2021

noot Nov 5, 2021

EclesioMeloJunior Nov 5, 2021

noot Nov 5, 2021

EclesioMeloJunior Nov 5, 2021

noot Nov 8, 2021 •

edited

Loading

EclesioMeloJunior Nov 8, 2021

noot left a comment

codecov bot commented Nov 9, 2021

github-actions bot commented Dec 3, 2021

+              	"sync"
+              )
+              var (

feat(lib/runtime): Implement ext_offchain_http_request_start_version_1 host function #1947

feat(lib/runtime): Implement ext_offchain_http_request_start_version_1 host function #1947

Conversation

EclesioMeloJunior commented Oct 31, 2021 • edited Loading

Changes

Tests

Issues

Primary Reviewer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noot Nov 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EclesioMeloJunior Nov 2, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arijitAD Nov 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noot Nov 8, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

noot left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 9, 2021

Codecov Report

github-actions bot commented Dec 3, 2021

feat(lib/runtime): Implement `ext_offchain_http_request_start_version_1` host function #1947

feat(lib/runtime): Implement `ext_offchain_http_request_start_version_1` host function #1947

EclesioMeloJunior commented Oct 31, 2021 •

edited

Loading

noot Nov 2, 2021 •

edited

Loading

EclesioMeloJunior Nov 2, 2021 •

edited

Loading

arijitAD Nov 1, 2021 •

edited

Loading

noot Nov 8, 2021 •

edited

Loading