Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/grandpa): clean up Grandpa tracked commit and vote messages #2478

Closed
wants to merge 2 commits into from

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Apr 12, 2022

Changes

  • Disable catch up response recording for now since it's unimplemented, to prevent a memory leak
  • Size driven cleanup, with a fixed maximum
    • Clean up vote messages by first in first out, by block hash + authority ID
    • Clean up commit messages by first in first out, by block hash
  • Investigate correct maximum size
  • Investigate how Subtrate does it

Tests

go test github.com/ChainSafe/gossamer/internal/grandpa/clean/...

Issues

#2398

Primary Reviewer

- Not implemented yet (see #1531)
- Can be a possible memory leak
@qdm12
Copy link
Contributor Author

qdm12 commented Apr 14, 2022

I'll re-open later once more appropriate changes are done.

@qdm12 qdm12 closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant