chore(dot/sync): blockQueue refactored
#2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #2563 +/- ##
===============================================
+ Coverage 57.53% 57.64% +0.11%
===============================================
Files 218 218
Lines 28664 28663 -1
===============================================
+ Hits 16491 16523 +32
+ Misses 10485 10455 -30
+ Partials 1688 1685 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
qdm12
force-pushed
the
qdm12/dot/sync/blockqueue
branch
2 times, most recently
from
f52f974
to
2a925c9
Compare
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
edwardmack
approved these changes
May 25, 2022
EclesioMeloJunior
approved these changes
May 25, 2022
qdm12
force-pushed
the
qdm12/dot/sync/blockqueue
branch
from
788cf07
to
2170947
Compare
- Context aware `pop` - Do not block `processReadyBlocks` forever on ctx cancel - Change mapping to hashes set (less memory usage) - Remove unneeded `cap int` field - More explicit variable names in block_queue.go
qdm12
force-pushed
the
qdm12/dot/sync/blockqueue
branch
from
2170947
to
bb4138f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
popprocessReadyBlocksforever on ctx cancelcap intfieldTests
go test -tags integration github.com/ChainSafe/gossamer/dot/syncIssues
Done whilst reviewing PR #2261
Primary Reviewer
@edwardmack