chore(telemetry): faster fail in case of dial error #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Time bound dialing (otherwise blocks for 30s) - Remove timer after failure - Lower max retries from 5 to 3
Codecov Report
@@ Coverage Diff @@
## development #2694 +/- ##
===============================================
- Coverage 62.82% 62.71% -0.12%
===============================================
Files 211 211
Lines 27000 26995 -5
===============================================
- Hits 16964 16929 -35
- Misses 8489 8519 +30
Partials 1547 1547
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
EclesioMeloJunior
approved these changes
Jul 25, 2022
jimjbrettj
approved these changes
Jul 25, 2022
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Encountered the problem due to bad CAs in the Docker image, making it stall foreeever (and adding Prometheus/Grafana and all that)
Tests
Issues
Related to #2693
Primary Reviewer
@timwu20