chore(lib/trie): database.go small simplifications #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/trie/database-simpl
branch
from
b6cb74c
to
331e7fe
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #2830 +/- ##
===============================================
- Coverage 63.32% 63.20% -0.13%
===============================================
Files 213 213
Lines 26979 26977 -2
===============================================
- Hits 17085 17051 -34
- Misses 8348 8381 +33
+ Partials 1546 1545 -1 |
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
qdm12
changed the title
qdm12
changed the title
timwu20
approved these changes
Sep 14, 2022
EclesioMeloJunior
approved these changes
Sep 14, 2022
- `DeleteFromDB` - `ClearPrefixFromDB`
qdm12
force-pushed
the
qdm12/trie/database-simpl
branch
from
331e7fe
to
68465ef
Compare
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PutInDBDeleteFromDBandClearPrefixFromDBand move them inline in trie testsTests
Issues
Primary Reviewer
@EclesioMeloJunior