chore(lib/keystore): LoadKeyStore more explicit
#2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/keystore/loadkeystore-refactor
branch
from
fc8011d
to
c9c5933
Compare
qdm12
changed the title
LoadKeyStore more explicit
qdm12
force-pushed
the
qdm12/keystore/loadkeystore-refactor
branch
from
c9c5933
to
bee68dc
Compare
qdm12
force-pushed
the
qdm12/local-interfaces
branch
2 times, most recently
from
ccb0f9b
to
d1f90f9
Compare
qdm12
force-pushed
the
qdm12/local-interfaces
branch
10 times, most recently
from
dc911f1
to
70a9ac3
Compare
qdm12
force-pushed
the
qdm12/keystore/loadkeystore-refactor
branch
from
bee68dc
to
53fc4c6
Compare
qdm12
force-pushed
the
qdm12/local-interfaces
branch
2 times, most recently
from
681c5de
to
ddc2964
Compare
qdm12
force-pushed
the
qdm12/local-interfaces
branch
3 times, most recently
from
a969af9
to
f89c898
Compare
qdm12
force-pushed
the
qdm12/local-interfaces
branch
2 times, most recently
from
b6e37ee
to
4982a91
Compare
qdm12
force-pushed
the
qdm12/local-interfaces
branch
2 times, most recently
from
c6e9924
to
d08d1da
Compare
qdm12
force-pushed
the
qdm12/keystore/loadkeystore-refactor
branch
from
53fc4c6
to
2edf344
Compare
qdm12
force-pushed
the
qdm12/keystore/loadkeystore-refactor
branch
from
2edf344
to
63d94c2
Compare
qdm12
requested review from
noot,
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj and
kishansagathiya
as code owners
EclesioMeloJunior
approved these changes
Jan 12, 2023
qdm12
force-pushed
the
qdm12/keystore/loadkeystore-refactor
branch
from
8475717
to
a5f7b27
Compare
timwu20
approved these changes
Jan 24, 2023
qdm12
force-pushed
the
qdm12/keystore/loadkeystore-refactor
branch
2 times, most recently
from
5435a4f
to
bb1c1ff
Compare
qdm12
force-pushed
the
qdm12/keystore/loadkeystore-refactor
branch
from
bb1c1ff
to
4bd77a6
Compare
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
From Eclesio's suggested changes in #2867
Change
lib/keystore'sLoadKeystoreto be more 'explicit', injecting the keyring as an argument, and moving the empty account key check up in the call stack.Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
Primary Reviewer
@EclesioMeloJunior