New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lib/sync): introduce `fullsync` strategy #4114

Open

EclesioMeloJunior wants to merge 83 commits into development from eclesio/sync-strategy

+2,727 −6,791

Member

EclesioMeloJunior commented Aug 6, 2024 •

edited

Loading

Changes

Remove dot/sync package
New sync package at lib/sync
Remove the concept of bootstrap and tip sync and just uses the fullsync as the default strategy
The SyncService uses the strategy approach as described in Refactor sync package to use the strategy approach #4112
This PR contains does not contains the concurrent request method process

Tests

go test -timeout 10m github.com/ChainSafe/gossamer/lib/sync --tags=integration -v

Issues

EclesioMeloJunior added 16 commits

July 5, 2024 09:57


          feat: implement in-memory-trie iterator and prefixed iterator

01b7bec


          chore: adjustment to fn replacement

d3004f9


          chore: add license and fix test

1bb4eda


          chore: fix lint issues

ef53a1f


          feat: remove usage of sorted keys

396b873


          chore: remove unneeded logger

53288b3


          wip sync

c8da583


          chore: strategies does not report or block peers

a591076


          wip: fullsync strategy working, need to polish the libsync servic

e9d1bcc


          Merge branch 'development' into eclesio/sync-strategy

93aca34


          chore: bring sync status

41dde9d


          chore: removing panics

88b7d3b


          chore: removing unneeded code

996baaa


          chore: add test TestFullSyncIsFinished

c1e43c8


          chore: use yaml file for test data


          chore: remove old sync package

316214a

EclesioMeloJunior requested review from jimjbrettj, timwu20 and kishansagathiya as code owners

August 6, 2024 22:25

EclesioMeloJunior added 6 commits

August 7, 2024 08:55


          Merge branch 'development' into eclesio/sync-strategy

1aa68d4


          chore: create unready_blocks.go

959769c


          chore: fix lint

b950cda


          chore: ignore forks when ancestor is behind highest finalized block

8479f23


          Merge branch 'eclesio/sync-strategy' of github.com:ChainSafe/gossamer…

124aca8

… into eclesio/sync-strategy


          chore: small updts

ec88b94

jimjbrettj reviewed

View reviewed changes

dot/services.go Outdated Show resolved Hide resolved

jimjbrettj reviewed

View reviewed changes

dot/services.go Outdated Show resolved Hide resolved

jimjbrettj reviewed

View reviewed changes

dot/services.go Outdated Show resolved Hide resolved

jimjbrettj reviewed

View reviewed changes

lib/common/variadic/uint32OrHash.go Outdated Show resolved Hide resolved

jimjbrettj reviewed

View reviewed changes

lib/sync/fullsync.go Outdated Show resolved Hide resolved

EclesioMeloJunior requested a review from jimjbrettj

September 17, 2024 22:46


          Merge branch 'eclesio/sync-strategy' of github.com:ChainSafe/gossamer…

6e38bdc

… into eclesio/sync-strategy

EclesioMeloJunior mentioned this pull request

investigation: Gossamer is not receiving Block Announcements #4178

Closed

2 tasks

EclesioMeloJunior added 2 commits

September 18, 2024 20:08


          improve test suite


          chore: remove target calculation using mean

2c11956

haikoschol reviewed

View reviewed changes

dot/sync/peer_view.go Outdated Show resolved Hide resolved

dot/sync/peer_view.go Outdated Show resolved Hide resolved

dot/sync/service.go Outdated Show resolved Hide resolved

dot/sync/worker_pool.go Outdated Show resolved Hide resolved

dot/sync/worker_pool.go Show resolved Hide resolved

dot/sync/fullsync.go Outdated Show resolved Hide resolved

dot/sync/fullsync.go Outdated Show resolved Hide resolved

dot/sync/fullsync.go Outdated Show resolved Hide resolved

dot/sync/fullsync.go Outdated Show resolved Hide resolved

dot/sync/fullsync_handle_block.go Outdated Show resolved Hide resolved


          chore: resolve lll

b6a0b9d

EclesioMeloJunior mentioned this pull request

feat(network/messages): normalize from_block field to be uint or common.Hash #4191

Merged

EclesioMeloJunior and others added 11 commits

September 19, 2024 18:25


          Update dot/sync/peer_view.go

d3920d1

Co-authored-by: Haiko Schol <539509+haikoschol@users.noreply.github.com>


          Update dot/sync/fullsync_handle_block.go

793295c

Co-authored-by: Haiko Schol <539509+haikoschol@users.noreply.github.com>


          chore: fix TestHandleBlockAnnounceMessage

b3e6bf4


          chore: fix TestFullSyncIsFinished

04540d1


          Merge branch 'development' into eclesio/sync-strategy

7f08a97


          chore: resolve all conflicts


          chore: rename IsFinished -> Process and add named returns

2ad6b37


          chore: fix small lint err

75a30cd


          chore: fix TestService_CreateBlockResponse

dff8a08


          chore: fix test TestFullSyncNextActions

50c4594


          chore: fix test `TestCreateNotificationsMessageHandler_BlockAnnounceH…

ee3380b

…andshake`

EclesioMeloJunior requested review from timwu20 and haikoschol

September 23, 2024 14:39

EclesioMeloJunior added 4 commits

September 23, 2024 19:46


          chore: solve discovery test problem

51e281c


          chore: fix TestFullSyncBlockAnnounce

f68623d


          chore: TestFullSyncBlockAnnounce

c7fc7b3


          chore: remove unneeded file

fc201d2

haikoschol approved these changes

View reviewed changes

EclesioMeloJunior added 4 commits

September 25, 2024 09:55


          Merge branch 'development' into eclesio/sync-strategy

2f4a242


          chore: fix deepsource

6da0e74


          Merge branch 'eclesio/sync-strategy' of github.com:ChainSafe/gossamer…

a8b7889

… into eclesio/sync-strategy


          chore: define min peers to 1

2f5c469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

haikoschol haikoschol approved these changes

edwardmack edwardmack approved these changes

P1sar P1sar approved these changes

kishansagathiya Awaiting requested review from kishansagathiya kishansagathiya is a code owner

jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

Requested changes must be addressed to merge this pull request.

Labels

None yet