scale: allocate slice elements when decoding #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noot
requested review from
edwardmack,
ansermino,
thomasmodeneis and
ryanchristo
noot
commented
Jan 31, 2020
| } | ||
|
|
||
| // TODO: finalize block actually returns a header, not a block. need to update this function | ||
| // as well as buildBlock |
ryanchristo
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Looks good to me! Also tested with updates in #572, which will now be unblocked!
thomasmodeneis
approved these changes
Feb 3, 2020
ryanchristo
pushed a commit
that referenced
this pull request
Jun 24, 2020
* update DecodeArray to allocate a slice instead of assigning to the interface that's passed in, allows for arrays to be decoded without knowing how many elements are in it * update DecodeTuple to handle [][]byte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests:
Issues:
closes #584