chore: remove node buffers #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to use node buffers, everything is `Uint8Array` compatible now. Needs the `libp2p-interfaces-compliance-tests` upgrade from ChainSafe#173 before CI will pass.
achingbrain
force-pushed
the
chore/remove-node-buffers
branch
from
cb3b5cc
to
b388009
Compare
vasco-santos
previously approved these changes
Dec 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 76.58% 76.58%
=======================================
Files 2 2
Lines 1905 1905
Branches 142 140 -2
=======================================
Hits 1459 1459
Misses 446 446 Continue to review full report at Codecov.
|
vasco-santos
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to use node buffers, everything is
Uint8Arraycompatible now.Needs the
libp2p-interfaces-compliance-testsupgrade from #173 before CI will pass.