feat: add runOnTransientConnection option to pass to registrar #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
fix/add-run-on-transient-option
branch
from
6fc011f
to
d5d2329
Compare
Adds an option to allow running gossipsub over transient (e.g. relayed) connections. By default this is not allowed since transient connections are by design data/time limited and breaching those limits can cause the connection to be closed abruptly, but sometimes people control the relay servers and disable the limits so allow them to use gossipsub over relayed connections if they choose.
achingbrain
force-pushed
the
fix/add-run-on-transient-option
branch
from
d5d2329
to
667a675
Compare
maschad
approved these changes
Jan 28, 2024
wemeetagain
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to allow running gossipsub over transient (e.g. relayed) connections.
By default this is not allowed since transient connections are by design data/time limited and breaching those limits can cause the connection to be closed abruptly, but sometimes people control the relay servers and disable the limits so allow them to use gossipsub over relayed connections if they choose.