Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @chainsafe/snappy-stream to 5.1.2 #5006

Closed
wants to merge 1 commit into from
Closed

Update @chainsafe/snappy-stream to 5.1.2 #5006

wants to merge 1 commit into from

Conversation

wemeetagain
Copy link
Member

@wemeetagain wemeetagain marked this pull request as ready for review January 13, 2023 19:15
@wemeetagain wemeetagain requested a review from a team as a code owner January 13, 2023 19:15
@github-actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 033849c Previous: 25417c6 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 1.0272 ms/op 1.0512 ms/op 0.98
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 62.644 us/op 61.216 us/op 1.02
BLS verify - blst-native 2.1723 ms/op 2.1723 ms/op 1.00
BLS verifyMultipleSignatures 3 - blst-native 4.4861 ms/op 4.4823 ms/op 1.00
BLS verifyMultipleSignatures 8 - blst-native 9.6937 ms/op 9.6970 ms/op 1.00
BLS verifyMultipleSignatures 32 - blst-native 35.245 ms/op 35.265 ms/op 1.00
BLS aggregatePubkeys 32 - blst-native 46.473 us/op 46.434 us/op 1.00
BLS aggregatePubkeys 128 - blst-native 182.31 us/op 182.28 us/op 1.00
getAttestationsForBlock 78.583 ms/op 79.502 ms/op 0.99
isKnown best case - 1 super set check 453.00 ns/op 445.00 ns/op 1.02
isKnown normal case - 2 super set checks 442.00 ns/op 434.00 ns/op 1.02
isKnown worse case - 16 super set checks 445.00 ns/op 432.00 ns/op 1.03
CheckpointStateCache - add get delete 8.3510 us/op 8.4810 us/op 0.98
validate gossip signedAggregateAndProof - struct 5.0153 ms/op 5.0178 ms/op 1.00
validate gossip attestation - struct 2.3611 ms/op 2.3607 ms/op 1.00
pickEth1Vote - no votes 2.2965 ms/op 2.2127 ms/op 1.04
pickEth1Vote - max votes 16.070 ms/op 17.066 ms/op 0.94
pickEth1Vote - Eth1Data hashTreeRoot value x2048 13.221 ms/op 13.771 ms/op 0.96
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 20.745 ms/op 21.630 ms/op 0.96
pickEth1Vote - Eth1Data fastSerialize value x2048 1.1380 ms/op 1.1148 ms/op 1.02
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.4868 ms/op 10.236 ms/op 0.93
bytes32 toHexString 964.00 ns/op 1.0050 us/op 0.96
bytes32 Buffer.toString(hex) 674.00 ns/op 673.00 ns/op 1.00
bytes32 Buffer.toString(hex) from Uint8Array 1.0180 us/op 1.0230 us/op 1.00
bytes32 Buffer.toString(hex) + 0x 672.00 ns/op 719.00 ns/op 0.93
Object access 1 prop 0.32200 ns/op 0.33200 ns/op 0.97
Map access 1 prop 0.30000 ns/op 0.31000 ns/op 0.97
Object get x1000 10.881 ns/op 10.717 ns/op 1.02
Map get x1000 0.96600 ns/op 0.95300 ns/op 1.01
Object set x1000 68.451 ns/op 77.392 ns/op 0.88
Map set x1000 44.869 ns/op 44.625 ns/op 1.01
Return object 10000 times 0.43270 ns/op 0.43620 ns/op 0.99
Throw Error 10000 times 6.6068 us/op 6.6178 us/op 1.00
fastMsgIdFn sha256 / 200 bytes 4.9480 us/op 4.9670 us/op 1.00
fastMsgIdFn h32 xxhash / 200 bytes 529.00 ns/op 576.00 ns/op 0.92
fastMsgIdFn h64 xxhash / 200 bytes 708.00 ns/op 742.00 ns/op 0.95
fastMsgIdFn sha256 / 1000 bytes 15.863 us/op 15.820 us/op 1.00
fastMsgIdFn h32 xxhash / 1000 bytes 698.00 ns/op 746.00 ns/op 0.94
fastMsgIdFn h64 xxhash / 1000 bytes 806.00 ns/op 845.00 ns/op 0.95
fastMsgIdFn sha256 / 10000 bytes 137.36 us/op 137.24 us/op 1.00
fastMsgIdFn h32 xxhash / 10000 bytes 2.5710 us/op 2.6370 us/op 0.97
fastMsgIdFn h64 xxhash / 10000 bytes 1.7710 us/op 1.8700 us/op 0.95
enrSubnets - fastDeserialize 64 bits 2.3510 us/op 2.5380 us/op 0.93
enrSubnets - ssz BitVector 64 bits 903.00 ns/op 974.00 ns/op 0.93
enrSubnets - fastDeserialize 4 bits 337.00 ns/op 387.00 ns/op 0.87
enrSubnets - ssz BitVector 4 bits 925.00 ns/op 966.00 ns/op 0.96
prioritizePeers score -10:0 att 32-0.1 sync 2-0 154.75 us/op 154.79 us/op 1.00
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 182.75 us/op 165.06 us/op 1.11
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 245.03 us/op 257.88 us/op 0.95
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 441.63 us/op 441.31 us/op 1.00
prioritizePeers score 0:0 att 64-1 sync 4-1 498.38 us/op 493.38 us/op 1.01
array of 16000 items push then shift 51.630 us/op 51.640 us/op 1.00
LinkedList of 16000 items push then shift 12.367 ns/op 12.636 ns/op 0.98
array of 16000 items push then pop 193.29 ns/op 195.38 ns/op 0.99
LinkedList of 16000 items push then pop 12.134 ns/op 12.291 ns/op 0.99
array of 24000 items push then shift 77.406 us/op 77.396 us/op 1.00
LinkedList of 24000 items push then shift 12.562 ns/op 12.989 ns/op 0.97
array of 24000 items push then pop 192.33 ns/op 196.67 ns/op 0.98
LinkedList of 24000 items push then pop 12.296 ns/op 12.365 ns/op 0.99
intersect bitArray bitLen 8 21.512 ns/op 22.072 ns/op 0.97
intersect array and set length 8 123.82 ns/op 129.37 ns/op 0.96
intersect bitArray bitLen 128 73.036 ns/op 72.933 ns/op 1.00
intersect array and set length 128 1.6769 us/op 1.7484 us/op 0.96
Buffer.concat 32 items 5.2080 us/op 4.5830 us/op 1.14
Uint8Array.set 32 items 3.7460 us/op 3.8160 us/op 0.98
pass gossip attestations to forkchoice per slot 5.8710 ms/op 3.7002 ms/op 1.59
computeDeltas 4.3296 ms/op 4.6152 ms/op 0.94
computeProposerBoostScoreFromBalances 2.4994 ms/op 2.5023 ms/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 3.4987 ms/op 3.5172 ms/op 0.99
altair processAttestation - 250000 vs - 7PWei worstcase 5.8960 ms/op 5.3602 ms/op 1.10
altair processAttestation - setStatus - 1/6 committees join 175.18 us/op 178.27 us/op 0.98
altair processAttestation - setStatus - 1/3 committees join 356.20 us/op 354.94 us/op 1.00
altair processAttestation - setStatus - 1/2 committees join 516.75 us/op 514.57 us/op 1.00
altair processAttestation - setStatus - 2/3 committees join 680.45 us/op 668.45 us/op 1.02
altair processAttestation - setStatus - 4/5 committees join 945.43 us/op 937.33 us/op 1.01
altair processAttestation - setStatus - 100% committees join 1.1308 ms/op 1.1229 ms/op 1.01
altair processBlock - 250000 vs - 7PWei normalcase 25.579 ms/op 23.581 ms/op 1.08
altair processBlock - 250000 vs - 7PWei normalcase hashState 34.713 ms/op 37.005 ms/op 0.94
altair processBlock - 250000 vs - 7PWei worstcase 73.358 ms/op 79.958 ms/op 0.92
altair processBlock - 250000 vs - 7PWei worstcase hashState 97.329 ms/op 109.18 ms/op 0.89
phase0 processBlock - 250000 vs - 7PWei normalcase 3.2388 ms/op 3.2874 ms/op 0.99
phase0 processBlock - 250000 vs - 7PWei worstcase 50.472 ms/op 51.390 ms/op 0.98
altair processEth1Data - 250000 vs - 7PWei normalcase 645.72 us/op 642.96 us/op 1.00
vc - 250000 eb 1 eth1 1 we 0 wn 0 - smpl 15 8.4370 us/op 7.6710 us/op 1.10
vc - 250000 eb 0.95 eth1 0.1 we 0.05 wn 0 - smpl 219 28.618 us/op 22.681 us/op 1.26
vc - 250000 eb 0.95 eth1 0.3 we 0.05 wn 0 - smpl 42 10.852 us/op 10.315 us/op 1.05
vc - 250000 eb 0.95 eth1 0.7 we 0.05 wn 0 - smpl 18 9.0250 us/op 7.9300 us/op 1.14
vc - 250000 eb 0.1 eth1 0.1 we 0 wn 0 - smpl 1020 103.42 us/op 88.521 us/op 1.17
vc - 250000 eb 0.03 eth1 0.03 we 0 wn 0 - smpl 11777 863.22 us/op 859.90 us/op 1.00
vc - 250000 eb 0.01 eth1 0.01 we 0 wn 0 - smpl 16384 1.1834 ms/op 1.1485 ms/op 1.03
vc - 250000 eb 0 eth1 0 we 0 wn 0 - smpl 16384 1.1494 ms/op 1.1076 ms/op 1.04
vc - 250000 eb 0 eth1 0 we 0 wn 0 nocache - smpl 16384 4.0165 ms/op 4.1858 ms/op 0.96
vc - 250000 eb 0 eth1 1 we 0 wn 0 - smpl 16384 2.3390 ms/op 2.5715 ms/op 0.91
vc - 250000 eb 0 eth1 1 we 0 wn 0 nocache - smpl 16384 7.1402 ms/op 6.7886 ms/op 1.05
Tree 40 250000 create 565.87 ms/op 604.41 ms/op 0.94
Tree 40 250000 get(125000) 265.47 ns/op 257.16 ns/op 1.03
Tree 40 250000 set(125000) 1.8369 us/op 2.0378 us/op 0.90
Tree 40 250000 toArray() 25.945 ms/op 26.428 ms/op 0.98
Tree 40 250000 iterate all - toArray() + loop 25.232 ms/op 26.662 ms/op 0.95
Tree 40 250000 iterate all - get(i) 100.69 ms/op 103.48 ms/op 0.97
MutableVector 250000 create 12.577 ms/op 14.459 ms/op 0.87
MutableVector 250000 get(125000) 10.810 ns/op 10.768 ns/op 1.00
MutableVector 250000 set(125000) 489.72 ns/op 502.99 ns/op 0.97
MutableVector 250000 toArray() 5.2172 ms/op 5.7847 ms/op 0.90
MutableVector 250000 iterate all - toArray() + loop 6.0319 ms/op 6.0660 ms/op 0.99
MutableVector 250000 iterate all - get(i) 3.2760 ms/op 2.7676 ms/op 1.18
Array 250000 create 5.2353 ms/op 5.9184 ms/op 0.88
Array 250000 clone - spread 1.9023 ms/op 2.6077 ms/op 0.73
Array 250000 get(125000) 0.95700 ns/op 1.2090 ns/op 0.79
Array 250000 set(125000) 0.98900 ns/op 1.1900 ns/op 0.83
Array 250000 iterate all - loop 151.57 us/op 150.93 us/op 1.00
effectiveBalanceIncrements clone Uint8Array 300000 32.102 us/op 43.378 us/op 0.74
effectiveBalanceIncrements clone MutableVector 300000 578.00 ns/op 806.00 ns/op 0.72
effectiveBalanceIncrements rw all Uint8Array 300000 243.80 us/op 243.84 us/op 1.00
effectiveBalanceIncrements rw all MutableVector 300000 132.71 ms/op 160.08 ms/op 0.83
phase0 afterProcessEpoch - 250000 vs - 7PWei 186.94 ms/op 198.07 ms/op 0.94
phase0 beforeProcessEpoch - 250000 vs - 7PWei 57.039 ms/op 56.527 ms/op 1.01
altair processEpoch - mainnet_e81889 520.23 ms/op 533.21 ms/op 0.98
mainnet_e81889 - altair beforeProcessEpoch 110.89 ms/op 119.33 ms/op 0.93
mainnet_e81889 - altair processJustificationAndFinalization 23.935 us/op 16.394 us/op 1.46
mainnet_e81889 - altair processInactivityUpdates 8.8670 ms/op 8.8747 ms/op 1.00
mainnet_e81889 - altair processRewardsAndPenalties 75.594 ms/op 76.993 ms/op 0.98
mainnet_e81889 - altair processRegistryUpdates 3.4620 us/op 2.3360 us/op 1.48
mainnet_e81889 - altair processSlashings 630.00 ns/op 560.00 ns/op 1.13
mainnet_e81889 - altair processEth1DataReset 835.00 ns/op 567.00 ns/op 1.47
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.9442 ms/op 2.2212 ms/op 0.88
mainnet_e81889 - altair processSlashingsReset 7.5170 us/op 4.0270 us/op 1.87
mainnet_e81889 - altair processRandaoMixesReset 5.9090 us/op 4.7570 us/op 1.24
mainnet_e81889 - altair processHistoricalRootsUpdate 676.00 ns/op 562.00 ns/op 1.20
mainnet_e81889 - altair processParticipationFlagUpdates 4.1510 us/op 1.7590 us/op 2.36
mainnet_e81889 - altair processSyncCommitteeUpdates 729.00 ns/op 666.00 ns/op 1.09
mainnet_e81889 - altair afterProcessEpoch 217.69 ms/op 197.26 ms/op 1.10
phase0 processEpoch - mainnet_e58758 598.85 ms/op 480.38 ms/op 1.25
mainnet_e58758 - phase0 beforeProcessEpoch 217.94 ms/op 172.92 ms/op 1.26
mainnet_e58758 - phase0 processJustificationAndFinalization 22.440 us/op 16.223 us/op 1.38
mainnet_e58758 - phase0 processRewardsAndPenalties 128.67 ms/op 65.762 ms/op 1.96
mainnet_e58758 - phase0 processRegistryUpdates 9.8370 us/op 8.1120 us/op 1.21
mainnet_e58758 - phase0 processSlashings 607.00 ns/op 539.00 ns/op 1.13
mainnet_e58758 - phase0 processEth1DataReset 795.00 ns/op 777.00 ns/op 1.02
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.9086 ms/op 1.6249 ms/op 1.17
mainnet_e58758 - phase0 processSlashingsReset 5.4990 us/op 3.1830 us/op 1.73
mainnet_e58758 - phase0 processRandaoMixesReset 5.8260 us/op 4.4510 us/op 1.31
mainnet_e58758 - phase0 processHistoricalRootsUpdate 671.00 ns/op 636.00 ns/op 1.06
mainnet_e58758 - phase0 processParticipationRecordUpdates 6.8420 us/op 3.6870 us/op 1.86
mainnet_e58758 - phase0 afterProcessEpoch 161.81 ms/op 168.40 ms/op 0.96
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.0760 ms/op 1.9403 ms/op 1.07
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.3512 ms/op 2.3761 ms/op 0.99
altair processInactivityUpdates - 250000 normalcase 47.650 ms/op 41.210 ms/op 1.16
altair processInactivityUpdates - 250000 worstcase 51.781 ms/op 32.854 ms/op 1.58
phase0 processRegistryUpdates - 250000 normalcase 7.1570 us/op 6.2120 us/op 1.15
phase0 processRegistryUpdates - 250000 badcase_full_deposits 538.81 us/op 370.40 us/op 1.45
phase0 processRegistryUpdates - 250000 worstcase 0.5 221.95 ms/op 197.46 ms/op 1.12
altair processRewardsAndPenalties - 250000 normalcase 133.55 ms/op 101.81 ms/op 1.31
altair processRewardsAndPenalties - 250000 worstcase 135.31 ms/op 74.368 ms/op 1.82
phase0 getAttestationDeltas - 250000 normalcase 11.081 ms/op 12.410 ms/op 0.89
phase0 getAttestationDeltas - 250000 worstcase 11.119 ms/op 12.439 ms/op 0.89
phase0 processSlashings - 250000 worstcase 5.3255 ms/op 5.3228 ms/op 1.00
altair processSyncCommitteeUpdates - 250000 304.51 ms/op 293.01 ms/op 1.04
BeaconState.hashTreeRoot - No change 467.00 ns/op 503.00 ns/op 0.93
BeaconState.hashTreeRoot - 1 full validator 66.120 us/op 73.914 us/op 0.89
BeaconState.hashTreeRoot - 32 full validator 710.92 us/op 651.98 us/op 1.09
BeaconState.hashTreeRoot - 512 full validator 8.4275 ms/op 6.8890 ms/op 1.22
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 88.915 us/op 134.02 us/op 0.66
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.4045 ms/op 1.2179 ms/op 1.15
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 16.341 ms/op 16.278 ms/op 1.00
BeaconState.hashTreeRoot - 1 balances 76.584 us/op 66.424 us/op 1.15
BeaconState.hashTreeRoot - 32 balances 719.88 us/op 652.42 us/op 1.10
BeaconState.hashTreeRoot - 512 balances 6.1747 ms/op 6.1905 ms/op 1.00
BeaconState.hashTreeRoot - 250000 balances 96.563 ms/op 100.02 ms/op 0.97
aggregationBits - 2048 els - zipIndexesInBitList 21.455 us/op 25.026 us/op 0.86
regular array get 100000 times 60.537 us/op 60.514 us/op 1.00
wrappedArray get 100000 times 60.527 us/op 60.513 us/op 1.00
arrayWithProxy get 100000 times 29.344 ms/op 26.470 ms/op 1.11
ssz.Root.equals 975.00 ns/op 961.00 ns/op 1.01
byteArrayEquals 966.00 ns/op 965.00 ns/op 1.00
shuffle list - 16384 els 11.371 ms/op 11.446 ms/op 0.99
shuffle list - 250000 els 167.30 ms/op 167.97 ms/op 1.00
processSlot - 1 slots 12.506 us/op 14.118 us/op 0.89
processSlot - 32 slots 1.8831 ms/op 1.9921 ms/op 0.95
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 346.14 us/op 335.88 us/op 1.03
getCommitteeAssignments - req 1 vs - 250000 vc 5.4346 ms/op 5.4381 ms/op 1.00
getCommitteeAssignments - req 100 vs - 250000 vc 7.9658 ms/op 7.9596 ms/op 1.00
getCommitteeAssignments - req 1000 vs - 250000 vc 8.4957 ms/op 8.5278 ms/op 1.00
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 8.4000 ns/op 7.7600 ns/op 1.08
state getBlockRootAtSlot - 250000 vs - 7PWei 1.1000 us/op 1.1765 us/op 0.93
computeProposers - vc 250000 17.656 ms/op 18.010 ms/op 0.98
computeEpochShuffling - vc 250000 171.27 ms/op 170.73 ms/op 1.00
getNextSyncCommittee - vc 250000 290.28 ms/op 291.05 ms/op 1.00

by benchmarkbot/action

@wemeetagain
Copy link
Member Author

closing in favor of #5001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wemeetagain