-
-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: async shuffling refactor #6938
Open
matthewkeil
wants to merge
79
commits into
unstable
Choose a base branch
from
mkeil/shuffling-refactor
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
46b6b3f
feat: add ShufflingCache to EpochCache
matthewkeil 99269ce
fix: implementation in state-transition for EpochCache with Shuffling…
matthewkeil 52187c9
feat: remove shufflingCache.processState
matthewkeil b6b2f20
feat: implement ShufflingCache changes in beacon-node
matthewkeil 4110dc0
feat: pass shufflingCache when loading cached state from db
matthewkeil 04e4a7b
test: fix state-transition tests for EpochCache changes
matthewkeil ff2d520
feat: Pass shufflingCache to EpochCache at startup
matthewkeil 53ed72e
test: fix slot off by one for decision root in perf test
matthewkeil 8faee3f
chore: use ?. syntax
wemeetagain d69c8b1
chore: refactoring
wemeetagain cfa97ad
feat: add comments and clean up afterProcessEpoch
matthewkeil 78a60a2
fix: perf test slot incrementing
matthewkeil 9b0ffe2
fix: remove MockShufflingCache
matthewkeil 13f5996
Revert "chore: refactoring"
matthewkeil d8d69c9
refactor: shufflingCache getters
matthewkeil 89798a5
refactor: shufflingCache setters
matthewkeil 81449e4
refactor: build and getOrBuild
matthewkeil 5799676
docs: add comments to ShufflingCache methods
matthewkeil 9a0ca70
chore: lint issues
matthewkeil 10dd105
test: update tests in beacon-node
matthewkeil bb3fd1c
chore: lint
matthewkeil 59f6d3f
feat: get shufflings from cache for API
matthewkeil bae40cc
feat: minTimeDelayToBuildShuffling cli flag
matthewkeil b8269ef
test: fix shufflingCache promise insertion test
matthewkeil a0e7e60
fix: rebase conflicts
matthewkeil ff7df85
fix: changes from debugging sim tests
matthewkeil 7468419
refactor: minimize changes in afterProcessEpoch
matthewkeil 9e5e4b0
chore: fix lint
matthewkeil 1988568
chore: fix check-types
matthewkeil 955c66c
chore: fix check-types
matthewkeil 389be49
feat: add diff utility
matthewkeil 529d85c
fix: bug in spec tests from invalid nextActiveIndices
matthewkeil dbf8ff1
refactor: add/remove comments
matthewkeil dea45b2
Merge branch 'unstable' into mkeil/shuffling-refactor
matthewkeil 5540ce1
refactor: remove this.activeIndicesLength from EpochCache
matthewkeil eb30b75
refactor: simplify shufflingCache.getSync
matthewkeil 6388a15
refactor: remove unnecessary undefined's
matthewkeil b2a7aa2
refactor: clean up ShufflingCache unit test
matthewkeil a8c0a6d
feat: add metrics for ShufflingCache
matthewkeil 40bb572
feat: add shufflingCache metrics to state-transition
matthewkeil dbe25c9
chore: lint
matthewkeil 70dc683
fix: metric name clash
matthewkeil 27081b2
refactor: add comment about not having ShufflingCache in EpochCache
matthewkeil 600acae
refactor: rename shuffling decision root functions
matthewkeil 8945e03
refactor: remove unused comment
matthewkeil 635d74c
feat: async add nextShuffling to EpochCache after its built
matthewkeil a2ad1ed
feat: make ShufflingCache.set private
matthewkeil db86883
feat: chance metrics to nextShufflingNotOnEpochCache instead of posit…
matthewkeil 7114aa5
refactor: move diff to separate PR
matthewkeil 4555604
chore: fix tests using shufflingCache.set method
matthewkeil d49bfee
feat: remove minTimeDelayToBuild
matthewkeil 923addb
feat: return promise from insertPromise and then through build
matthewkeil 1613d8f
fix: update metrics names and help field
matthewkeil 0a64e36
feat: move build of shuffling to beforeProcessEpoch
matthewkeil ed850ee
feat: allow calc of pivot slot before slot increment
matthewkeil 5e65f7e
fix: calc of pivot slot before slot increment
matthewkeil 2c1100c
Revert "fix: calc of pivot slot before slot increment"
matthewkeil d5317ec
Revert "feat: allow calc of pivot slot before slot increment"
matthewkeil 82ac512
feat: allow getting current block root for shuffling calculation
matthewkeil aa9ab9c
fix: get nextShufflingDecisionRoot directly from state.blockRoots
matthewkeil ca8445a
fix: convert toRootHex
matthewkeil 19ae447
docs: add comment about pulling decisionRoot directly from state
matthewkeil ff6694d
feat: add back metrics for regen attestation cache hit/miss
matthewkeil 1a7ab44
docs: fix docstring on shufflingCache.build
matthewkeil 85a9ae1
refactor: change validatorIndices to Uint32Array
matthewkeil ee1256e
refactor: remove comment and change variable name
matthewkeil eff10c4
fix: use toRootHex instead of toHexString
matthewkeil 4d06deb
refactor: deduplicate moved function computeAnchorCheckpoint
matthewkeil 1ab811c
fix: touch up metrics per PR comments
matthewkeil 0e8eeb7
Merge branch 'unstable' into mkeil/shuffling-refactor
matthewkeil fd8196e
fix: merge conflict
matthewkeil 4f777c8
chore: lint
matthewkeil 222908c
refactor: add scope around activeIndices to GC arrays
matthewkeil ffbbfea
feat: directly use Uint32Array instead of transcribing number array t…
matthewkeil 7f6d420
refactor: activeIndices per tuyen comment
matthewkeil afc03f2
refactor: rename to epochAfterNext
matthewkeil d1d0e22
chore: review PR
twoeths c5c5772
feat: update no shuffling ApiError to 500 status
matthewkeil 88d3105
fix: add back unnecessary eslint directive. to be remove under separa…
matthewkeil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be aligned to the other error