Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix api handler used during testing #7047

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Aug 23, 2024

Motivation

Fix e2e tests on electra branch, see job run

Description

Fix api handler used during testing by supplying api module to call to set as this object

async submitPoolAttestations({signedAttestations}) {
await this.submitPoolAttestationsV2({signedAttestations});
},

@nflaig nflaig requested a review from a team as a code owner August 23, 2024 10:29
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.39%. Comparing base (e35ff4a) to head (81b6d7a).
Report is 1 commits behind head on electra-fork-rebasejul30.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           electra-fork-rebasejul30    #7047   +/-   ##
=========================================================
  Coverage                     49.39%   49.39%           
=========================================================
  Files                           589      589           
  Lines                         39217    39217           
  Branches                       2245     2249    +4     
=========================================================
  Hits                          19372    19372           
  Misses                        19804    19804           
  Partials                         41       41           

@nflaig nflaig merged commit 499cf57 into electra-fork-rebasejul30 Aug 23, 2024
17 of 18 checks passed
@nflaig nflaig deleted the nflaig/fix-e2e-tests branch August 23, 2024 11:11
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.22.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants