Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-build PeerTube again in dev Dockerfile. #251

Merged
merged 2 commits into from
Jan 25, 2018

Conversation

jankeromnes
Copy link
Contributor

PeerTube pre-build was removed in #207 because npm run dev already builds it on-the-fly (see this comment).

However, I find that npm run dev takes too long to produce an initial build, causing errors when you try to use PeerTube right after starting npm run dev.

I feel like including a pre-built PeerTube in dev images is valuable and convenient. @Chocobozzz please have a look when you have time.

PeerTube pre-build was removed in Chocobozzz#207 but is still valuable.
@jankeromnes
Copy link
Contributor Author

Additionally, building PeerTube within the dev Dockerfile has the merit of failing the Docker automated build if the PeerTube build contains errors. This prevents accidentally shipping dev images with a dysfunctional PeerTube build.

@jankeromnes
Copy link
Contributor Author

From the #peertube IRC channel on Freenode:

14:11:57 janx> Chocobozzz: when I try to access port :3000 it says "Invalid Host header"
14:18:46 @Chocobozzz> hum
14:25:02 @Chocobozzz> janx: seems to be webpack/webpack-dev-server#882
14:27:26 @Chocobozzz> janx: could you update your pr to use this workaround? angular/angular-cli#6349 (comment)

@Chocobozzz Chocobozzz merged commit 42f1923 into Chocobozzz:develop Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants