Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing bug with huntbot giving incorrect xp to pets on both teams #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sfk-steelsong
Copy link
Contributor

pet xp rewrite, now it all goes through petUtil and properly handles active / inactive team

@sfk-steelsong sfk-steelsong mentioned this pull request Sep 17, 2021
@sfk-steelsong
Copy link
Contributor Author

Honestly, after looking at this again, I'd prefer to simplify the logic to make it easier to understand:

  1. catch up xp applies to everything (hunts + huntbot) instead of just battles
  2. show catch up xp multiplier on the team view
  3. inactive team still gets half xp (and no bonus xp from battles ?)

Right now, this replicates the current logic across all 4 sources of xp (hunting, huntbot, battling manually, and your team being encountered in a battle), but I think that'd make things simpler to understand for users and can make that change if you're interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant