Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate to openBox(p) on count==1 #293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Delegate to openBox(p) on count==1 #293

wants to merge 2 commits into from

Conversation

ms5984
Copy link

@ms5984 ms5984 commented Sep 10, 2022

I need help to check that this works/doesn't cause problems, but I think this can fix #292

Togira123
Togira123 suggested changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@Togira123 Togira123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use strict comparison (===) instead of ==

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Togira123 Togira123 Togira123 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repeated logic leading to message quirk
2 participants
@ms5984 @Togira123