-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for alternate url bindings for actions #37
Conversation
b179307
to
b80c33f
Compare
stripes-web/src/main/java/org/stripesframework/web/controller/UrlBindingFactory.java
Outdated
Show resolved
Hide resolved
stripes-web/src/main/java/org/stripesframework/web/controller/UrlBindingFactory.java
Show resolved
Hide resolved
if ( conflicts.size() == 1 ) { | ||
if ( resolvedConflicts == null ) { | ||
resolvedConflicts = new LinkedHashSet<>(); | ||
// this cannot work since conflicts.get(0) returns an UrlBinding but PathCache is a Map<String, UrlBinding> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get that comment, could you explain it a bit more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_pathCache.get() takes a String as an Argument while conflicts.get(0) returns an UrlBinding
--> ergo _patchCache.get(UrlBinding) will return null and will not work.
No description provided.