Add support for alternate url bindings for actions #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRittler
force-pushed
the
additional-url-bindings
branch
from
b179307
to
b80c33f
Compare
kelunik
reviewed
Jul 3, 2024
stripes-web/src/main/java/org/stripesframework/web/controller/UrlBindingFactory.java
Outdated
Show resolved
Hide resolved
stripes-web/src/main/java/org/stripesframework/web/controller/UrlBindingFactory.java
Show resolved
Hide resolved
kelunik
reviewed
Jul 8, 2024
| if ( conflicts.size() == 1 ) { | ||
| if ( resolvedConflicts == null ) { | ||
| resolvedConflicts = new LinkedHashSet<>(); | ||
| // this cannot work since conflicts.get(0) returns an UrlBinding but PathCache is a Map<String, UrlBinding> |
There was a problem hiding this comment.
I don't get that comment, could you explain it a bit more?
There was a problem hiding this comment.
_pathCache.get() takes a String as an Argument while conflicts.get(0) returns an UrlBinding
--> ergo _patchCache.get(UrlBinding) will return null and will not work.
kelunik
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.