-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major: Orb Tools Version 12 #181
Conversation
fe6f6a3
to
29284d8
Compare
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Was it intentional to remove |
Hey @wyardley Yes! We changed away from statically defined images, where we were required to pass through parameters such as You should now be able to do something like looks like this: orbs:
orb-tools: circleci/orbtools@12
executors:
my-exec:
docker:
- image: cimg/base:stable
resource_class: small
workflows:
example:
jobs:
- orb-tools/pack:
executor: my-exec Now the executor can come from anywhere, such as an orb, or be defined locally. When defined, or redefined locally, we can pass any parameters we want into the definition of the executor. |
Probably should have been called out in the migration guide and / or breaking changes for 12.x? IIRC, this used to not be possible? Can you give an example of using an upstream orb, but overriding a parameter like For me, the following gives an error orbs:
orb-tools: circleci/orb-tools@12.0.0
executors:
orb-tools:
name: orb-tools/default
resource_class: small
workflows:
test-pack:
jobs:
- orb-tools/lint:
executor: orb-tools
IIRC, this used to be impossible, but maybe something has changed and I just have the wrong syntax? (and, if it's not possible anymore, what can orb-tools-orb/src/executors/default.yml Lines 11 to 15 in d82dc25
|
Orb Tools 12
⭐ Dynamic Orb Injection Without Publication
The major goal of this PR is to decrease friction in orb contributions. Currently, in order to contribute to an orb, you must have access to a secured Restricted Context in CircleCI which contains a publishing token, so that a development version of the orb may be tested in the following dynamic workflow. This means, when a contributor opens a PR, they must wait for a maintainer to re-push the code for the proper permissions. This slows down the dev cycle a lot.
With this change, rather than publishing a new development version of the orb, we modify the dynamic config template to inject the orb source as an "internal" orb within the continue job. This has the same net-effect for testing your orbs but not longer requires access to secrets, eliminating blockers top the PR process.
Other Improvements
Blocked By
orb init
CLI command