Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: promote macOS aarch64 to official support #1025

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Since I have a macOS M1 laptop to test on now, I think it's a good time to bump it to being officially supported, especially since it's going to be the main macOS platform for the foreseeable feature.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang force-pushed the make_m1_macos_official branch 2 times, most recently from 56309e9 to c0f8468 Compare February 19, 2023 05:46
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Base: 21.31% // Head: 21.31% // No change to project coverage 👍

Coverage data is based on head (f23dd1f) compared to base (f89b243).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1025   +/-   ##
=======================================
  Coverage   21.31%   21.31%           
=======================================
  Files          75       75           
  Lines       14754    14754           
=======================================
  Hits         3145     3145           
  Misses      11609    11609           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Since I have a macOS M1 laptop to test on now, I think it's a good time
to bump it to be officially supported, especially since it's going
to be the main macOS platform for the foreseeable feature.
@ClementTsang ClementTsang marked this pull request as ready for review February 19, 2023 06:12
@ClementTsang ClementTsang merged commit 2a1c410 into master Feb 19, 2023
@ClementTsang ClementTsang deleted the make_m1_macos_official branch February 19, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant