Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing parent section names in TOML #1551

Merged

Conversation

Frederick888
Copy link
Contributor

Description

The filters didn't have their parent section names, and were parsed as top-level items.

Issue

Filters not working.

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.92%. Comparing base (218d189) to head (5da011d).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1551       +/-   ##
===========================================
+ Coverage   41.20%   53.92%   +12.72%     
===========================================
  Files         113      113               
  Lines       17808    17808               
===========================================
+ Hits         7337     9603     +2266     
+ Misses      10471     8205     -2266     
Flag Coverage Δ
macos-12 36.63% <ø> (ø)
ubuntu-latest 56.53% <ø> (+13.37%) ⬆️
windows-2019 36.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang
Copy link
Owner

ClementTsang commented Aug 7, 2024

Oops, that's my bad. Thanks for fixing. Surprised the validation didn't catch that, I'll take a look at that later...

EDIT: #1552

@ClementTsang ClementTsang merged commit 4c83672 into ClementTsang:main Aug 7, 2024
36 checks passed
@Frederick888 Frederick888 deleted the fix-default-config-toml branch August 8, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants