Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: show N/A for Nvidia GPUs if we detect one but can't get temps #1557

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 11, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Something that I noticed; if we do see GPUs but can't get the temp, it's probably fine to return N/A rather than no entry at all.

Issue

If applicable, what issue does this address?

Possibly related to #1554?

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 58.53659% with 17 lines in your changes missing coverage. Please review.

Project coverage is 35.96%. Comparing base (c65121c) to head (199d95e).

Files Patch % Lines
src/data_collection/nvidia.rs 0.00% 8 Missing ⚠️
src/app/filter.rs 71.42% 6 Missing ⚠️
src/data_collection/network/sysinfo.rs 0.00% 1 Missing ⚠️
src/data_collection/temperature/sysinfo.rs 0.00% 1 Missing ⚠️
src/options.rs 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c65121c) and HEAD (199d95e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c65121c) HEAD (199d95e)
ubuntu-latest 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
- Coverage   41.41%   35.96%   -5.45%     
==========================================
  Files         114      108       -6     
  Lines       17847    16844    -1003     
==========================================
- Hits         7391     6058    -1333     
- Misses      10456    10786     +330     
Flag Coverage Δ
macos-12 36.71% <58.53%> (-0.02%) ⬇️
ubuntu-latest ?
windows-2019 36.91% <58.53%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang marked this pull request as ready for review August 11, 2024 20:54
@ClementTsang ClementTsang merged commit d9d9e1d into main Aug 11, 2024
36 checks passed
@ClementTsang ClementTsang deleted the shown_na_for_failed_nvidia_gpu_temps branch August 11, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant