-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: try using GHA instead of Cirrus for FreeBSD in basic CI #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementTsang
force-pushed
the
freebsd-ci-try-vm
branch
4 times, most recently
from
September 3, 2024 01:53
1b444c4
to
7adf19e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1577 +/- ##
==========================================
+ Coverage 41.63% 41.65% +0.01%
==========================================
Files 114 114
Lines 17893 17893
==========================================
+ Hits 7450 7453 +3
+ Misses 10443 10440 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ClementTsang
force-pushed
the
freebsd-ci-try-vm
branch
from
September 3, 2024 07:32
67d0e82
to
1dd5388
Compare
ClementTsang
changed the title
ci: try using cross for FreeBSD in PR CI workflow
ci: try using FreeBSD VM in PR CI workflow
Sep 3, 2024
ClementTsang
changed the title
ci: try using FreeBSD VM in PR CI workflow
ci: try using GHA instead of Cirrus for FreeBSD in basic CI
Sep 3, 2024
ClementTsang
force-pushed
the
freebsd-ci-try-vm
branch
3 times, most recently
from
September 3, 2024 07:48
1a603f7
to
c087204
Compare
ClementTsang
force-pushed
the
freebsd-ci-try-vm
branch
from
September 3, 2024 08:06
f3f7bd0
to
f3a7ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Ideally we minimize our usage of Cirrus CI, especially for typical PR CI workflows, since it's a bit cludgy to work with. This method is also more extendable to things like OpenBSD. After this PR, we no longer should be using Cirrus anywhere in our default workflow except for deploys.
On that note, at least for now, I guess it's fine for deploys since that's not super frequent and at this point I have that working fairly well when automated + I don't usually have to wait for it, as opposed to PRs where I may commit many times.
Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)