Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: try using GHA instead of Cirrus for FreeBSD in basic CI #1577

Merged
merged 14 commits into from
Sep 3, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Sep 2, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Ideally we minimize our usage of Cirrus CI, especially for typical PR CI workflows, since it's a bit cludgy to work with. This method is also more extendable to things like OpenBSD. After this PR, we no longer should be using Cirrus anywhere in our default workflow except for deploys.

On that note, at least for now, I guess it's fine for deploys since that's not super frequent and at this point I have that working fairly well when automated + I don't usually have to wait for it, as opposed to PRs where I may commit many times.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang force-pushed the freebsd-ci-try-vm branch 4 times, most recently from 1b444c4 to 7adf19e Compare September 3, 2024 01:53
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.65%. Comparing base (7c35def) to head (f3a7ecd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
+ Coverage   41.63%   41.65%   +0.01%     
==========================================
  Files         114      114              
  Lines       17893    17893              
==========================================
+ Hits         7450     7453       +3     
+ Misses      10443    10440       -3     
Flag Coverage Δ
macos-12 36.94% <ø> (ø)
ubuntu-latest 43.38% <ø> (+0.01%) ⬆️
windows-2019 36.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang changed the title ci: try using cross for FreeBSD in PR CI workflow ci: try using FreeBSD VM in PR CI workflow Sep 3, 2024
@ClementTsang ClementTsang changed the title ci: try using FreeBSD VM in PR CI workflow ci: try using GHA instead of Cirrus for FreeBSD in basic CI Sep 3, 2024
@ClementTsang ClementTsang force-pushed the freebsd-ci-try-vm branch 3 times, most recently from 1a603f7 to c087204 Compare September 3, 2024 07:48
@ClementTsang ClementTsang enabled auto-merge (squash) September 3, 2024 07:53
@ClementTsang ClementTsang enabled auto-merge (squash) September 3, 2024 07:53
@ClementTsang ClementTsang merged commit 1a71520 into main Sep 3, 2024
35 of 36 checks passed
@ClementTsang ClementTsang deleted the freebsd-ci-try-vm branch September 3, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant