Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added named colour support + rgb colour support in config files. #22

Merged
merged 1 commit into from
Feb 23, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Feb 23, 2020

Description

Adds named colour support + rgb colour support to config files. Prior to this, only support for hex codes was available - now, we support 3 methods of colour naming.

So, this is now totally valid:

ram_color="0, 0, 255"
swap_color="#fffeee"
rx_color="magenta"

An example of this using purely "magenta" in most fields:
image

Issue

Issue: #15

Type of change

Remove the irrelevant one.

  • New feature (non-breaking change which adds functionality)

Checklist

  • Code has been linted
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced
  • Documentation has been added

Other information

Provide any other relevant information.

@ClementTsang ClementTsang merged commit 8d23f06 into master Feb 23, 2020
@ClementTsang ClementTsang deleted the named_colour_and_rgb_support branch February 23, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add colour name (at least default colours) and RGB support in config
1 participant