Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix missing config options in docs and default config #542

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jul 14, 2021

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

Adds the missing hide_time and battery config option to the default config and corresponding documentation.

Should probably automate the generation of this somehow tbh, though this might change when I add in-app config (soon™)

Issue

If applicable, what issue does this address?

Closes: #541

Testing

If relevant, please state how this was tested. All changes must be tested to work:

Furthermore, mark which platforms this change was tested on. All platforms directly affected by the change must be tested

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts

@ClementTsang ClementTsang changed the title bug: Fix missing hide_time config option in docs and default config bug: Fix missing config options in docs and default config Jul 14, 2021
@ClementTsang ClementTsang merged commit 968b7bb into master Jul 14, 2021
@ClementTsang ClementTsang deleted the fix_missing_config_option branch July 14, 2021 23:08
ClementTsang added a commit that referenced this pull request Jul 14, 2021
Adds the missing hide_time and battery config option to the default config and corresponding documentation.

Should probably automate the generation of this somehow tbh, though this might change when I add in-app config (soon™)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated config generated on first run
1 participant