Add support for nvidia GPUs #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=========================================
+ Coverage 7.21% 7.84% +0.62%
=========================================
Files 52 53 +1
Lines 8238 8278 +40
=========================================
+ Hits 594 649 +55
+ Misses 7644 7629 -15
Continue to review full report at Codecov.
|
|
Sorry for taking so long to getting around to review this. Tested on my Windows VM, worked fine there too with grabbing my passed-through 1050 Ti. Code also looks good to me. Thanks for this! @all-contributors add @shurizzle for code |
|
I've put up a pull request to add @shurizzle! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the support for nvidia's GPUs temperature using the crate nvml-wrapper that load the nvml library only if it exists, so you can use it optionally even if the nvidia flag is setted. Interestingly on my test on my Windows machine no sensors are found except the nvidia's one. I tested it on Windows 10 with GeForce 1080, on the same machine with ArchLinux and on a Mid 2014 MacBook Pro 14" Retina. I let the tests run on Github Actions' CI and seems that nothing brokes.
Here some screenshots:
Windows 10:
ArchLinux:
MacOS:
