Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clean up CI workflow #720

Merged
merged 3 commits into from
May 1, 2022
Merged

ci: clean up CI workflow #720

merged 3 commits into from
May 1, 2022

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented May 1, 2022

Description

A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:

Cleaned up and updated the primary GitHub CI workflow. Also fixes a bug caught during this check.

Testing

Tested by this PR, which should trigger the CI workflow.

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts

@ClementTsang ClementTsang force-pushed the ci_shortening branch 3 times, most recently from 68e2194 to 6e50da1 Compare May 1, 2022 20:39
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #720 (a92313a) into master (e646a76) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #720   +/-   ##
=======================================
  Coverage   20.78%   20.78%           
=======================================
  Files          53       53           
  Lines       13618    13620    +2     
=======================================
+ Hits         2830     2831    +1     
- Misses      10788    10789    +1     
Impacted Files Coverage Δ
src/options.rs 61.78% <42.85%> (-0.04%) ⬇️
src/clap.rs 99.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e646a76...a92313a. Read the comment docs.

@ClementTsang ClementTsang merged commit c44e860 into master May 1, 2022
@ClementTsang ClementTsang deleted the ci_shortening branch May 1, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants