Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: basic sortable disk #870

Merged
merged 1 commit into from
Nov 6, 2022
Merged

feature: basic sortable disk #870

merged 1 commit into from
Nov 6, 2022

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Nov 6, 2022

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Adds basic sorting + shortcuts for disk.

image
image

Issue

If applicable, what issue does this address?

Closes: #567

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov-commenter
Copy link

Codecov Report

Base: 18.67% // Head: 18.55% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (b63cd2b) compared to base (4d9f509).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
- Coverage   18.67%   18.55%   -0.13%     
==========================================
  Files          74       74              
  Lines       13604    13696      +92     
==========================================
  Hits         2541     2541              
- Misses      11063    11155      +92     
Impacted Files Coverage Δ
src/app.rs 0.00% <0.00%> (ø)
src/app/widgets/cpu_graph.rs 0.00% <0.00%> (ø)
src/app/widgets/disk_table.rs 0.00% <0.00%> (ø)
src/bin/main.rs 39.17% <0.00%> (-0.62%) ⬇️
src/lib.rs 6.37% <0.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang marked this pull request as ready for review November 6, 2022 06:34
@ClementTsang ClementTsang merged commit 36837ae into master Nov 6, 2022
@ClementTsang ClementTsang deleted the disk_widget_sort branch November 6, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting feature for Disks table
2 participants