other: non-normalized process CPU% cleanup and docs #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementTsang
changed the title
ClementTsang
force-pushed
the
non_normalized_cpu_followup
branch
from
7d4b087
to
23e26b9
Compare
ClementTsang
commented
Nov 21, 2022
| pub fn get_process_data( | ||
| prev_idle: &mut f64, prev_non_idle: &mut f64, | ||
| pid_mapping: &mut FxHashMap<Pid, PrevProcDetails>, use_current_cpu_total: bool, | ||
| per_core_percentage: bool, time_difference_in_secs: u64, mem_total_kb: u64, logical_count: u64, | ||
| normalization: CpuUsageStrategy, time_difference_in_secs: u64, mem_total_kb: u64, |
There was a problem hiding this comment.
Can also probably combine use_current_cpu_total to CpuUsageStrategy in a later cleanup PR.
ClementTsang
force-pushed
the
non_normalized_cpu_followup
branch
2 times, most recently
from
a30df3b
to
50b7ceb
Compare
ClementTsang
force-pushed
the
non_normalized_cpu_followup
branch
3 times, most recently
from
28400f6
to
bdcecf6
Compare
ClementTsang
force-pushed
the
non_normalized_cpu_followup
branch
from
bdcecf6
to
bb20390
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Some cleanup around the non-normalized process CPU% feature, and updating relevant documentation. Also renames the flag to
unnormalized_cpu, though I'm open to changing it.Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)