other: slightly reduce the CPU time spent for draws #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to draw each data set separately as a new canvas. Now, in one canvas, we draw all datasets. Note that this changes how dataset lines are drawn - rather than drawing one on top of another, it now draws kinda all at once. This effect is *kinda* a bit better IMO, but it might also look a bit more cluttered.
Codecov ReportBase: 19.24% // Head: 19.22% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
==========================================
- Coverage 19.24% 19.22% -0.02%
==========================================
Files 74 74
Lines 14069 14094 +25
==========================================
+ Hits 2708 2710 +2
- Misses 11361 11384 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ClementTsang
force-pushed
the
reduce_draw_cpu_usage
branch
2 times, most recently
from
66ab3b4
to
a42dfdd
Compare
Flamegraphs showed that this area seems to be a bit heavy at times with some inefficient use of iterators and collection. This change should hopefully optimize this a bit by reducing some collections or reallocations. There can also be some further optimizations with less allocations from callers.
ClementTsang
force-pushed
the
reduce_draw_cpu_usage
branch
from
a42dfdd
to
e59b4fc
Compare
ClementTsang
force-pushed
the
reduce_draw_cpu_usage
branch
from
5626d69
to
bdb64a2
Compare
ClementTsang
changed the title
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Slightly reduces CPU time spent on drawing through two small changes:
truncate_texta bit.The first change results in graphs with a lot of stacked datasets like the "all" CPU graph looking like this instead:
(For small graphs with few/one dataset, it looks the same):
We can replicate the old effect by switching layers on each draw, but I'm not sure if it's better or worse.
Perfromance-wise can see the general effects through flamegraphs (
cargo flamegraph --bin btm, withdebug = trueandstrip = false):Before the change, drawing took almost 40% of the flamegraph time (measured over ~30 minutes):
After, it's taking only about 14% (also ~30 minutes):
The other usage from the flamegraph is about the same, so it should hopefully be a reasonable comparison. Running the pre-change and post-change binaries together also shows less CPU time spent on the post-change binary.
Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt)README.md, help menu, doc pages, etc.)