Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding default expanded option to commandline and config (closes #822) #919

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Adding default expanded option to commandline and config (closes #822) #919

merged 3 commits into from
Dec 7, 2022

Conversation

sou-chon
Copy link
Contributor

@sou-chon sou-chon commented Nov 28, 2022

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Addresses #822: Adding option to expand widgets on startup. Also adding the corresponding option to config file.

Issue

If applicable, what issue does this address?

Closes: #822

Testing

If relevant, please state how this was tested. All changes must be tested to work:

testing by debug_assert() from clap.

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Base: 19.24% // Head: 20.07% // Increases project coverage by +0.82% 🎉

Coverage data is based on head (3ebce13) compared to base (913c9ed).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
+ Coverage   19.24%   20.07%   +0.82%     
==========================================
  Files          74       74              
  Lines       14069    14246     +177     
==========================================
+ Hits         2708     2860     +152     
- Misses      11361    11386      +25     
Impacted Files Coverage Δ
src/app.rs 0.00% <0.00%> (ø)
src/constants.rs 0.00% <ø> (ø)
src/options.rs 42.35% <0.00%> (-0.62%) ⬇️
src/clap.rs 100.00% <100.00%> (ø)
src/bin/main.rs 36.58% <0.00%> (-0.86%) ⬇️
src/canvas/canvas_colours.rs 34.24% <0.00%> (-0.51%) ⬇️
src/widgets/process_table/proc_widget_data.rs 9.79% <0.00%> (-0.07%) ⬇️
src/lib.rs 6.12% <0.00%> (-0.06%) ⬇️
src/canvas/widgets/cpu_graph.rs 0.00% <0.00%> (ø)
src/canvas/widgets/mem_graph.rs 0.00% <0.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sou-chon sou-chon changed the title [#822] adding default expanded option to commandline and config Adding default expanded option to commandline and config (closes #822) Nov 28, 2022
@ClementTsang ClementTsang self-assigned this Nov 29, 2022
@ClementTsang
Copy link
Owner

Thanks for the PR, will check in a bit.

Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long, left a few small comments, mostly just nitpicking.

EDIT: Also did a quick check on my Linux machine for sanity's sake, seems fine functionality-wise.

src/clap.rs Outdated Show resolved Hide resolved
src/constants.rs Outdated Show resolved Hide resolved
src/options.rs Outdated Show resolved Hide resolved
@alexleduc76
Copy link

Thank you for this!

Will you make a new release soon? Just wondering if I should clone the branch and build it myself, or wait for an official release (if one of coming soon).

@ClementTsang
Copy link
Owner

ClementTsang commented Dec 2, 2022

@alexleduc76 I want to get an official stable release out before end of year.

That being said I have daily nightly builds automatically created that might be of interest at https://github.com/ClementTsang/bottom/releases/tag/nightly

@sou-chon
Copy link
Contributor Author

sou-chon commented Dec 2, 2022

@ClementTsang updated

src/options.rs Outdated Show resolved Hide resolved
@ClementTsang
Copy link
Owner

Looks good, thanks for everything!

@all-contributors please add @sou-chon for code.

@allcontributors
Copy link
Contributor

@ClementTsang

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @sou-chon! 🎉

@ClementTsang ClementTsang merged commit 4272dd0 into ClementTsang:master Dec 7, 2022
@sou-chon sou-chon deleted the 822-add-default-expand branch December 7, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to launch a specific widget already maximized, without having to press "e" manually
4 participants