Avoid std::terminate in write buffers #8384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
added
the
pr-bugfix
vitlibar
pushed a commit
that referenced
this pull request
Dec 26, 2019
…-buffers Avoid std::terminate in write buffers (cherry picked from commit c949eb5)
vitlibar
pushed a commit
to vitlibar/ClickHouse
that referenced
this pull request
Dec 26, 2019
…e-in-write-buffers Avoid std::terminate in write buffers (cherry picked from commit c949eb5)
vitlibar
pushed a commit
that referenced
this pull request
Dec 26, 2019
…-buffers Avoid std::terminate in write buffers (cherry picked from commit c949eb5)
vitlibar
pushed a commit
that referenced
this pull request
Dec 26, 2019
…-buffers Avoid std::terminate in write buffers (cherry picked from commit c949eb5)
vitlibar
pushed a commit
that referenced
this pull request
Dec 27, 2019
…-buffers Avoid std::terminate in write buffers (cherry picked from commit c949eb5)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Fixed possible server crash (
std::terminate) when the server cannot send or write data in JSON or XML format with values of String data type (that require UTF-8 validation) or when compressing result data with Brotli algorithm or in some other rare cases. This fixes #7603Detailed description (optional):
This PR also contains commits from #8380 due to occasion.