Fix wrong data path in DatabaseMemory #8753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavplubix
added
the
pr-bugfix
dbms/src/Storages/StorageFactory.cpp
Outdated
| @@ -132,6 +132,12 @@ StoragePtr StorageFactory::get( | |||
| } | |||
| } | |||
|
|
|||
| if (relative_data_path.empty()) | |||
| { | |||
| if (endsWith(name, "MergeTree") || endsWith(name, "Log") || name == "Join" || name == "Set") | |||
There was a problem hiding this comment.
If it means "all table engines that store data on disk", I would add Distributed,
but better to just remove that if,
because if relative path is empty, it is logical error anyway?
There was a problem hiding this comment.
Distributed and File can be created with empty path
There was a problem hiding this comment.
Let's add a virtual method to IStorage?
There was a problem hiding this comment.
Or, better - check for nonempty path in storages constructor?
alexey-milovidov
requested changes
Jan 20, 2020
tavplubix
pushed a commit
that referenced
this pull request
Jan 21, 2020
…ta_path Fix wrong data path in DatabaseMemory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
In 20.1.1
Memorydatabases use empty data path, so tables are created inpathdirectory (e.g./var/lib/clickhouse/), not in data directory of database (e.g./var/lib/clickhouse/db_name).