Proper processing of exception in write_suffix in Kafka #9507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, but before commit. Fixes ClickHouse#9378
|
test failure 00910_zookeeper_test_alter_compression_codecs seems unrelated |
alexey-milovidov
approved these changes
Mar 4, 2020
nikitamikhaylov
pushed a commit
that referenced
this pull request
Mar 5, 2020
Proper processing of exception in write_suffix in Kafka (cherry picked from commit 4629f78)
nikitamikhaylov
pushed a commit
that referenced
this pull request
Mar 5, 2020
Proper processing of exception in write_suffix in Kafka (cherry picked from commit 4629f78)
nikitamikhaylov
pushed a commit
that referenced
this pull request
Mar 5, 2020
Proper processing of exception in write_suffix in Kafka (cherry picked from commit 4629f78)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Prevent losing data in Kafka in rare cases when exception happens after reading suffix but before commit. Fixes #9378
Detailed description / Documentation draft:
Related: #7175