Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free compressor's buffer when FreeBufOnConnRelease enabled #1100

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

cergxx
Copy link
Contributor

@cergxx cergxx commented Sep 21, 2023

Summary

Additional fix to #1086
In #1091 I added a FreeBufOnConnRelease option to drop connections' buffers.
It turned out that this option would only make sense if it dropped compressor's buffer as well.

Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkaflik jkaflik merged commit 93692b6 into ClickHouse:main Oct 3, 2023
13 checks passed
@cergxx cergxx deleted the also-free-compressor-buf branch October 3, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants