Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cargo-codspeed): set verbosity to normal #15

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Sep 6, 2023

Summary

cargo codspeed is printing with --verbose, which fills the log with lots of compilation messages that are uninteresting to normal users.

e.g. build benchmark step in https://github.com/web-infra-dev/oxc/actions/runs/6095539763/job/16539311128
image

This PR sets the verbosity to normal.

Test Plan

I ran the built binary on my project and sees no compilation messages.

@art049
Copy link
Member

art049 commented Sep 12, 2023

Great, thank you! Merging this as well!

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 12, 2023

CodSpeed Performance Report

Merging #15 will degrade performances by 12.44%

Comparing Boshen:verbose (1621b66) with main (87506ab)

Summary

❌ 2 (👁 2) regressions
✅ 52 untouched benchmarks

Benchmarks breakdown

Benchmark main Boshen:verbose Change
👁 Auto 195.6 ns 223.3 ns -12.44%
👁 Linear 195.6 ns 223.3 ns -12.44%

@art049 art049 merged commit 1621b66 into CodSpeedHQ:main Sep 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants