Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back buttons to several pages #217

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Add back buttons to several pages #217

merged 7 commits into from
Aug 29, 2024

Conversation

dinoboy197
Copy link
Contributor

Add back buttons to several UI pages.

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hierr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 3:51am

@dinoboy197
Copy link
Contributor Author

@avenmia I've rebased this against main but I cannot test it fully locally due to #222 . Once #222 is resolved, I'll be able to test all of the pages and make sure that back buttons work correctly.

@dinoboy197
Copy link
Contributor Author

@avenmia ready for review :)

Comment on lines 303 to 305
<IoMdArrowBack />
Homepage
</button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to Home instead of Homepage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 164 to 166
<IoMdArrowBack />
Go back to Address entry
</button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say "Re-enter Address"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 64 to 66
<IoMdArrowBack />
Go back to Demographic Survey
</button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's say Retake Demographic Survey

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines 225 to 227
<IoMdArrowBack />
Go back to Address entry
</button>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this one. "Re-enter Address"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 62 to 64
<IoMdArrowBack />
Return to polis survey selection
</Link>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're updating the names, this might be better as "Select New Polis Survey"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@avenmia avenmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks!

@dinoboy197 dinoboy197 merged commit 068bf86 into main Aug 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants