Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use either spelling of defence / defense #50

Conversation

jackbrown1993
Copy link

No description provided.

@Coffee-fueled-deadlines
Copy link
Owner

This will error out when you do user.skill('defense') or user.skill('defense') as you've put if skill = 'defense': skill = 'defence' but left it spelled defense in the skills list. I suggest swapping those around and doing if skill = 'defence': skill = 'defense' instead.

@Coffee-fueled-deadlines
Copy link
Owner

Check the above workflow:

=========================== short test summary info ============================
FAILED OSRSBytes/tests/hiscores_test.py::test - OSRSBytes.Hiscores.SkillError: ERROR: skill 'defence' does not exist
==================== 1 failed, 1 passed, 1 warning in 3.61s ====================

@jackbrown1993
Copy link
Author

How do you run the tests?

@jackbrown1993
Copy link
Author

This will error out when you do user.skill('defense') or user.skill('defense') as you've put if skill = 'defense': skill = 'defence' but left it spelled defense in the skills list. I suggest swapping those around and doing if skill = 'defence': skill = 'defense' instead.

I think I did this in the original pull request my bad... will fix and start paying more attention :)

@Coffee-fueled-deadlines
Copy link
Owner

How do you run the tests?

The tests are available to run when a Pull request is made. I think I have to approve them but I could look into modifying that. If you forked it, they should appear under actions at the top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants