Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs vars to work with RTD changes #6410

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Jackenmen
Copy link
Member

Description of the changes

Few small changes to accommodate the planned removal of Sphinx context injection on RTD.

Depending on what changes are made to sphinx-rtd-theme, more changes may be needed.

Have the changes in this PR been tested?

No

It is not possible to test this until Sphinx context injection is disabled for all existing projects on RTD. Either way, I did base this on RTD's compatibility extension:
https://github.com/readthedocs/sphinx-build-compatibility/blob/58aabc5f207c6c2421f23d3578adc0b14af57047/sphinx_build_compatibility/extension.py#L123

@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 17, 2024
@github-actions github-actions bot added the Category: Meta This is related to the repository maintenance. label Jul 17, 2024
@Kowlin Kowlin merged commit 005b8af into Cog-Creators:V3/develop Sep 11, 2024
18 checks passed
@red-githubbot red-githubbot bot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Sep 11, 2024
@Jackenmen Jackenmen deleted the support_for_rtd_changes branch September 11, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Meta This is related to the repository maintenance. Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants