Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ansible Lint Config #10025

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 5, 2023

Description:

Add fqcn[action] and name[template] to warn list.

Rationale:

So the tests pass.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jan 5, 2023

Code Climate has analyzed commit 9ce8282 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.8% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 marked this pull request as ready for review January 6, 2023 13:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 6, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 6, 2023
@Mab879 Mab879 added the Infrastructure Our content build system label Jan 6, 2023
@marcusburghardt marcusburghardt self-assigned this Jan 9, 2023
@marcusburghardt
Copy link
Member

@Mab879 , how do you recommend to test this locally?

@Mab879
Copy link
Member Author

Mab879 commented Jan 9, 2023

@Mab879 , how do you recommend to test this locally?

I roughly followed Ansible Lint Gating Job locally.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fqcn[action] warning must be fixed, but it should be done gradually considering the necessary efforts. It is fine to just warn about it for now so the CI tests are green again.

Thanks @Mab879 .

@marcusburghardt marcusburghardt merged commit 124b512 into ComplianceAsCode:master Jan 10, 2023
@Mab879 Mab879 deleted the ansible_lint_fix branch January 10, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants