Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts clean up #10061

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 13, 2023

Description:

Removes the following scripts:

  • utils/find_shadowed_files.py
  • utils/xccdf2csv-stig.py

Rationale:

Keep the repository clean.

Review Hints:

Each commit gives details on why I removed the script.

This script seems to no longer work and no longer used.
It seems to longer being used and based on of utils/rule_dir_json.py
I think the output of this script is wrong.
@Mab879 Mab879 added the Infrastructure Our content build system label Jan 13, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 13, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jan 13, 2023

Code Climate has analyzed commit b1361c2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.8% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt self-assigned this Jan 14, 2023
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mab879 . I agree and confirm the information from the commit messages.

@marcusburghardt marcusburghardt merged commit 4a6560f into ComplianceAsCode:master Jan 18, 2023
@Mab879 Mab879 deleted the scripts_clean_up branch January 18, 2023 14:07
Mab879 added a commit to Mab879/content that referenced this pull request May 5, 2023
Mab879 added a commit to Mab879/content that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants