Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 2 rules for 15 related to nftables #10068

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Added 2 rules for 15 related to nftables #10068

merged 1 commit into from
Jan 18, 2023

Conversation

rumch-se
Copy link
Contributor

Description:

  • Two rules package_nftables_removed and service_nftables_disabled added to SLE 15 profile

Rationale:

  • The rules cover CIS requirement 3.5.1.2 Ensure nftables is not installed or stopped and masked.

@rumch-se rumch-se requested a review from a team as a code owner January 17, 2023 09:36
@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 17, 2023
@github-actions
Copy link

github-actions bot commented Jan 17, 2023 •
edited
Loading

Start a new ephemeral environment with changes proposed in this pull request:

sle15 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@rumch-se rumch-se force-pushed the rule_package_nftables_removed branch from 715e72d to 8729624 Compare January 17, 2023 09:52
@codeclimate
Copy link

codeclimate bot commented Jan 17, 2023

Code Climate has analyzed commit 8729624 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added SLES SUSE Linux Enterprise Server product related. New Rule Issues or pull requests related to new Rules. CIS CIS Benchmark related. labels Jan 17, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 17, 2023
@Mab879 Mab879 self-assigned this Jan 18, 2023
Mab879
Mab879 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@Mab879
Copy link
Member

Mab879 commented Jan 18, 2023

The Automatus failures are expected as the prodtype only has sle15.

@Mab879 Mab879 merged commit 55d0980 into ComplianceAsCode:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. SLES SUSE Linux Enterprise Server product related.
Projects
None yet
Milestone
0.1.66
Development

Successfully merging this pull request may close these issues.
2 participants
@rumch-se @Mab879