Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Ubuntu products in package_prelink_removed #10071

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Jan 17, 2023

Description:

  • The package_prelink_removed rule is also applicable for Ubuntu

Rationale:

  • This rule can cover benchmarks requirements, like CIS for Ubuntu 20.04 and Ubuntu 22.04.

@dodys dodys requested a review from a team as a code owner January 17, 2023 16:07
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Jan 17, 2023
@Mab879 Mab879 added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 17, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 17, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 17, 2023

Code Climate has analyzed commit 0695954 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

@Mab879
Copy link
Member

Mab879 commented Jan 17, 2023

Waving the Ansible findings as we need shell functionally for this check.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding the CODEOWNERS since @dodys can't approve this PR since @dodys opened it.

@Mab879 Mab879 merged commit 4800080 into ComplianceAsCode:master Jan 17, 2023
@dodys dodys deleted the prelink branch April 17, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants