Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account_emergency_expire_date to OL7 stig #10073

Merged

Conversation

freddieRv
Copy link
Contributor

Description:

  • Add account_emergency_expire_date rule to the OL7 stig profile

Rationale:

  • OL7 DISA STIG efforts

@freddieRv freddieRv requested a review from a team as a code owner January 17, 2023 17:37
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added this to the 0.1.66 milestone Jan 17, 2023
@Mab879 Mab879 added Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates. STIG STIG Benchmark related. labels Jan 17, 2023
@Mab879 Mab879 self-assigned this Jan 17, 2023
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR; just one minor change is needed.

Signed-off-by: Federico Ramirez <federico.r.ramirez@oracle.com>
@freddieRv freddieRv force-pushed the ol7-account_emergency_expire_date branch from a39274e to 688ecc3 Compare January 17, 2023 19:20
@codeclimate
Copy link

codeclimate bot commented Jan 17, 2023

Code Climate has analyzed commit 688ecc3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM. Overriding the CODEOWNERS file since @freddieRv can't approve this PR.

@Mab879
Copy link
Member

Mab879 commented Jan 17, 2023

Waving Ansible lint as these changes did not change any Ansible remediations.

@Mab879 Mab879 merged commit a749643 into ComplianceAsCode:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Oracle Linux Oracle Linux product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants