Introduce script shorthand to OVAL #10085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method OVALTester._expand_shorthand is a private method used as helper in the CTest test "macros-oval". But, it might be useful not only in this test, so we will move it to the ssg module and make it a public function.
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
Reduce code complexity to satisfy CodeClimate.
|
I have addressed the CodeClimate problem. |
Mab879
reviewed
Jan 24, 2023
This is a simple end-to-end test for utils/shorthand_to_oval.py
|
Code Climate has analyzed commit 5e6ca9e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 49.5% (-0.2% change). View more on Code Climate. |
|
/packit retest-failed |
Mab879
approved these changes
Jan 25, 2023
|
Waving the CodeClimate findings as one, they related to the reorganization of code, and two there are end to end tests for the new code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduce a small script
shorthand_to_oval.pythat converts (resolved) shorthand OVAL files to a valid OVAL file.It's based on already existing code from the CTest test "macros-oval".
Rationale:
The script can be useful for example when creating minimal bug reproducers. If you know that a problem is located in OVAL for a specific rule, you can use it to convert a resolved shorthand OVAL files from the
build/product/checks/ovaldirectory to a standalone valid OVAL file that you can then pass tooscap.Review Hints:
For more details, please read the commit messages of every commit.