Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Ubuntu products in two nftables rules #10101

Merged
merged 6 commits into from
Jan 20, 2023
Merged

Include Ubuntu products in two nftables rules #10101

merged 6 commits into from
Jan 20, 2023

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Jan 20, 2023

Description:

  • The package_nftables_removed and service_nftables_disabled rules are also applicable for Ubuntu

Rationale:

  • These rules can cover benchmarks requirements, like CIS for Ubuntu 20.04 and Ubuntu 22.04.

@dodys dodys requested a review from a team as a code owner January 20, 2023 16:55
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 self-assigned this Jan 20, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 20, 2023

Code Climate has analyzed commit 2e6b6b2 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 added this to the 0.1.66 milestone Jan 20, 2023
@Mab879 Mab879 added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Jan 20, 2023
Mab879
Mab879 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Overriding the CODEOWNERS protection due @dodys being the only Ubuntu approver.

@Mab879 Mab879 merged commit 5ab1a13 into ComplianceAsCode:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
CIS CIS Benchmark related. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.66
Development

Successfully merging this pull request may close these issues.
2 participants
@dodys @Mab879