Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move two rules to higher level in cis_rhel8 control file #10109

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Move two rules to higher level in cis_rhel8 control file #10109

merged 1 commit into from
Jan 23, 2023

Conversation

vojtapolasek
Copy link
Collaborator

Description:

  • move rule sudo_require_authentication and kernel_module_squashfs_disabled to level 2 for server and workstation in RHEL8 CIS

Rationale:

Review Hints:

  • build the content and check for example HTML guides for CIS server level 1 and CIS server level 2

@vojtapolasek
move two rules to higher level in cis_rhel8
f5e643f 
This is according to the benchmark.
@vojtapolasek vojtapolasek added bugfix Fixes to reported bugs. Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. CIS CIS Benchmark related. labels Jan 23, 2023
@vojtapolasek vojtapolasek added this to the 0.1.66 milestone Jan 23, 2023
@vojtapolasek vojtapolasek requested a review from a team as a code owner January 23, 2023 09:48
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

marcusburghardt
marcusburghardt approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the levels in these two rules were wrong. Thanks for updating @vojtapolasek .

@marcusburghardt marcusburghardt self-assigned this Jan 23, 2023
@codeclimate
Copy link

codeclimate bot commented Jan 23, 2023

Code Climate has analyzed commit f5e643f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt merged commit 673ddc0 into ComplianceAsCode:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
bugfix Fixes to reported bugs. CIS CIS Benchmark related. RHEL8 Red Hat Enterprise Linux 8 product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.66
Development

Successfully merging this pull request may close these issues.
2 participants
@vojtapolasek @marcusburghardt