-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
products/alinux2 && products/alinux3: fix some missing rules in the cis profile #10138
products/alinux2 && products/alinux3: fix some missing rules in the cis profile #10138
Conversation
Hi @hustliyilin. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for this profile update.
Please note that currently when you add a rule to CIS profile, you should also modify the rule.yml file and ensure that the cis@alinux2 and cis@alinux3 references are there.
Please update references of rules.
0a727fb
to
f508ee8
Compare
Signed-off-by: YuQing <yyq0391@163.com> Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
f508ee8
to
06ae8b1
Compare
Signed-off-by: YuQing <yyq0391@163.com> Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
06ae8b1
to
d36d72f
Compare
Code Climate has analyzed commit d36d72f and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.7% (0.0% change). View more on Code Climate. |
Hi @vojtapolasek , Thanks a lot. I have modified the codes according to your review suggestion. Now CI/CDs are passed. I would be very grateful if you could review this PR again. Thanks again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you.
Description:
There are some missing rules updated by this repo recently, so we need to
update them in both Alibaba Cloud Linux 2 and Alibaba Cloud Linux 3.
Fixes #products/alinux2 && products/alinux3: fix some missing rules in the profiles. #10137