Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

products/alinux2 && products/alinux3: fix some missing rules in the cis profile #10138

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

hustliyilin
Copy link
Contributor

Description:

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2023

Hi @hustliyilin. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@vojtapolasek vojtapolasek self-assigned this Jan 30, 2023
Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for this profile update.
Please note that currently when you add a rule to CIS profile, you should also modify the rule.yml file and ensure that the cis@alinux2 and cis@alinux3 references are there.
Please update references of rules.

controls/cis_alinux3.yml Outdated Show resolved Hide resolved
controls/cis_alinux3.yml Outdated Show resolved Hide resolved
controls/cis_alinux3.yml Outdated Show resolved Hide resolved
@jan-cerny jan-cerny changed the title products/alinux2 && products/alinux3: fix some missing rules in the cis profile. products/alinux2 && products/alinux3: fix some missing rules in the cis profile Feb 10, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Feb 14, 2023
Signed-off-by: YuQing <yyq0391@163.com>
Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
Signed-off-by: YuQing <yyq0391@163.com>
Signed-off-by: YiLin.Li <YiLin.Li@linux.alibaba.com>
@codeclimate
Copy link

codeclimate bot commented Feb 14, 2023

Code Climate has analyzed commit d36d72f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

@hustliyilin
Copy link
Contributor Author

Hi @vojtapolasek

Thanks a lot. I have modified the codes according to your review suggestion. Now CI/CDs are passed. I would be very grateful if you could review this PR again. Thanks again.

Copy link
Collaborator

@vojtapolasek vojtapolasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@vojtapolasek vojtapolasek merged commit 28c4376 into ComplianceAsCode:master Feb 14, 2023
@vojtapolasek vojtapolasek added Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. Alibaba Linux Alibaba Linux product related. labels Feb 14, 2023
@vojtapolasek vojtapolasek added this to the 0.1.67 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Alibaba Linux Alibaba Linux product related. CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants