Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL 9 STIG Update Q1 2023 #10185

Merged

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Feb 8, 2023

Description:

Update the RHEL 9 STIG based on latest changes.

Rationale:

Keep the content up to date.

Review Hints:

Use ./utils/srg_diff.py to help compare.

@Mab879 Mab879 added RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related. labels Feb 8, 2023
@Mab879 Mab879 added this to the 0.1.67 milestone Feb 8, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Feb 8, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 force-pushed the import_rhel9_stig_feb_2023 branch 2 times, most recently from 184494f to d7fa5cd Compare February 13, 2023 16:18
Various white spaces to remove extra blank lines.
Due to the nature of the import process.
Causes some rendering issues if this is not done
The install line was missing before and causing issues.
@Mab879 Mab879 marked this pull request as ready for review February 14, 2023 23:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Feb 14, 2023
Rules that are staying that are not in the spreadsheet.
* Audit rules are being kept since we don't combine like DISA
* file_*_cron_* are kept due to some wild carding in some rules. We will need to replace these in the future, once everything is finalized.
* There a few rules for FIPS and donf rules that we need for technical reasons
* set_password_hashing_algorithm_* to ensure that CCE-83615-5 CCE-83621-3 are fully covered
@marcusburghardt marcusburghardt self-assigned this Feb 23, 2023
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I saw only some minor details.

Mab879 added a commit to Mab879/content that referenced this pull request Feb 28, 2023
Mab879 added a commit to Mab879/content that referenced this pull request Feb 28, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 1, 2023

Code Climate has analyzed commit d9fb321 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked all the changes and the are sane. Nice work @Mab879 .

@marcusburghardt marcusburghardt added the Highlight This PR/Issue should make it to the featured changelog. label Mar 1, 2023
@marcusburghardt marcusburghardt merged commit 3acc3ea into ComplianceAsCode:master Mar 1, 2023
@Mab879 Mab879 deleted the import_rhel9_stig_feb_2023 branch March 1, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Highlight This PR/Issue should make it to the featured changelog. RHEL9 Red Hat Enterprise Linux 9 product related. STIG STIG Benchmark related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants